search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.54k stars 822 forks source link

Inconsistent tunnel=yes rendering for streams, drains and ditches #3676

Open xkomczax opened 5 years ago

xkomczax commented 5 years ago

There is inconsistency for rendering tag+key values tunnel=yes on waterway=stream.

On zoom level 13, the stream is not rendered. On zoom level 14, the stream is rendered as regular waterway. On zoom level 15, the stream is rendered with dashed line symbolizing tunnel.

My concern here is about zoom level 14: it should either not be rendered (the same as zoom 0-13) or rendered by a dashed line (the same as zoom level 15-19). Now it appears as "normal" waterway just for one zoom level, which is strange.

(just to note: the whole area I am linking is a karst zone with underground creeks/rivers, so it is tagged correctly).

kocio-pl commented 5 years ago

Thanks for the report. Are you interested in fixing this issue?

jeisenbe commented 5 years ago

It should be easy to fix this by removing rendering for streams underground / in tunnels at z14

jeisenbe commented 5 years ago

the whole area I am linking is a karst zone with underground creeks/rivers, so it is tagged correctly

@imagico disagreed with the statement above. A tunnel=yes is usually a man-made feature. Natural waterways in caves are not normally mapped, because it is not possible for mappers to determine the course of the waterway underground with GPS.

Example from above: https://www.openstreetmap.org/#map=14/49.3840/16.7393 z15-suchdol-underground-streams

It's hard to see how the courses of these streams could have been mapped correctly.

jragusa commented 5 years ago

I fully agree, a karst system is not as simple as we can expect, you can also have diffuse infiltration and some part are inaccessible for humans, limiting accurate mapping. Note also that most of karst map are vertical (regarding to the depth) and not horizontal.

jeisenbe commented 4 years ago

@imagico your comment in https://github.com/gravitystorm/openstreetmap-carto/pull/3938#issuecomment-544477109 suggests that you might want to close this issue as not fixable. Is that correct?

imagico commented 4 years ago

The reason for this issue is that stream rendering has been removed from z13 without consideration for the zoom level progression otherwise leading to the observations of this issue. Generally speaking i think rendering stream tunnels like normal streams at the lower zoom levels is a valid cartographic choice while not rendering them while normal streams are rendered otherwise leaving gaps (#3938) is not.

I would consider this issue to be about reviewing the zoom level progression of small waterways rendering for consistent and intuitive results after #3467.

jeisenbe commented 4 years ago

It would be good to open up a specific issue about the initial zoom level

At the time of #3467 I had hoped that we might just remove intermittent=yes streams from z13 (which cause most of the visual problems in the USA, since the imports are quite agressive about labeling any sort of tiny intermittent watercourse) while keeping permanent streams.

On 1/9/20, Christoph Hormann notifications@github.com wrote:

The reason for this issue is that stream rendering has been removed from z13 without consideration for the zoom level progression otherwise leading to the observations of this issue. Generally speaking i think rendering stream tunnels like normal streams at the lower zoom levels is a valid cartographic choice while not rendering them while normal streams are rendered otherwise leaving gaps (#3938) is not.

I would consider this issue to be about reviewing the zoom level progression of small waterways rendering for consistent and intuitive results after

3467.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/gravitystorm/openstreetmap-carto/issues/3676#issuecomment-572563425

imagico commented 4 years ago

Well - the problems of current stream rendering were not solved by removing them from z13, they were just hidden. There are other maps which render streams from z12 already with reasonable results so this is not really a matter of what is and is not possible to depict but of how to show it in a way that is well readable.

Starting intermittent streams one zoom level later is a possibility but it will only work if it is still an intuitive and well readable rendering otherwise.