Specific icon for office=government

[jeisenbe]

Since #3163 all office=* features have a dot and text label rendering, including office=government.

However, this feature is worth rendering in a specific way.

The tag office=government is the most frequent value of the key office=, currently used 130,000 times , (22% of all values) and in many countries government offices are significant destinations.

The Humanitarian map style renders office=government, office=ngo and amenity=townhall with unique icons which share some styling features:

• https://github.com/hotosm/HDM-CartoCSS/blob/master/icons/poi/government.svg
• https://github.com/hotosm/HDM-CartoCSS/tree/master/icons/poi/ngo.svg
• https://github.com/hotosm/HDM-CartoCSS/tree/master/icons/poi/townhall.svg

[Adamant36]

The town hall link is 404ing because it shouldn't have _ in the file name. Otherwise, good suggestion.

[geowas-github]

Good, also because office=government and ngo is somewhat distinct to the more commercial ones (office=company and alike). I would keep the office blue, though, plus it makes sense to move amenity=townhall to the blue color as well.

[Adamant36]

plus it makes sense to move amenity=townhall to the blue color as well

Why? It's totally an amenity.

[geowas-github]

plus it makes sense to move amenity=townhall to the blue color as well

Why? It's totally an amenity.

Because it is (also) a town-administrational office. So it could make sense that is shares the colour of office=administration.

[Adamant36]

Because it is (also) a town-administrational office

I think the overall building would be considered an amenity. Whereas, the individual offices could be tagged separately as such. People use the townhall building as an amenity more then they do the individual offices. Plus, the offices usually have their own separate contact information. So it would make sense to tag them separately if need be. Like in the town hall of my city there was a floor dedicated to the police dispatch for awhile and there's also a separate area in the building for the government run electric company to pay bills and whatnot. It makes zero sense to tag individual places like that as amenities inside and office (as in your case), but it makes total sense to individual tag a few offices inside a larger amenity. Kind of like is currently done for supermarkets with pharmacy counters. Not to mention there was probably good reasons why OSM decided to go with the amenity tag for town halls and not office=*. That seems like the best reason to keep it amenity color.

[Adamant36]

One more thing. To me an amenity is a characteristic of a thing. Whereas an office is a physical feature. I don't think they are mutually exclusive. It just makes more intuitive sense for some reason to tag an office inside a larger building tagged as an amenity instead of the other way around. It's a matter of scope and category. Like, you can have the electricity go out in one room and still have it be on for the rest of the building, but you can't have the electricity go out for the whole building but still have it be on for one room. If that makes any sense.

[geowas-github]

Good points. Ok with me to keep amenity brown for town halls.