gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.54k stars 823 forks source link

Rendering tidal flats #387

Closed malcolmh closed 9 years ago

malcolmh commented 10 years ago

It appears that all areas tagged "natural=wetland" are rendered with the reed-bed pattern, regardless of the "wetland=xxx" or "surface=xxx" tags. Since the reed-bed pattern implies vegetation, this rendering is inappropriate for areas without vegetation. In particular, areas that have "wetland=tidalflat" together with "surface=mud" or "surface=sand" should be rendered with the same pattern as the existing rendering of "natural=mud" and "natural=sand"

matkoniecz commented 10 years ago

I think that also in this case orienteering maps have a nice symbol set, maybe one of them would fit well.

beztytuu

EdLoach commented 10 years ago

See also https://trac.openstreetmap.org/ticket/1607 I think

matthijsmelissen commented 10 years ago

Yes, that's the same issue.

matkoniecz commented 10 years ago

wetland is in database

23cpo commented 10 years ago

Yes, it would be nice to see the different types of wetlands on the map. Some proposed symbols can be found here: http://wiki.openstreetmap.org/wiki/Key:wetland#Rendering_.28proposal.29 symbols

daganzdaanda commented 10 years ago

Good idea! Randomized symbols like in #938 would look good.

Very often you see wetland tagged overlapping water or meadow. That may be because people don't like the empty grey background, or because it does seem to add additional info. But isn't that bad tagging? The examples on the wiki show green and grey backgrounds. I think we should maybe use a green background with blue symbols for one group, and green on blue for the other.

matkoniecz commented 10 years ago

wetland + meadow/forest/whatever is frequently a proper way to tag areas.

daganzdaanda commented 10 years ago

wetland + meadow/forest/whatever is frequently a proper way to tag areas.

I used to think that, too, but I'm not sure anymore.

wetland + meadow is probably wetland=wetmeadow. wetland + forest should most probably be a swamp or mangrove. wetland=reedbed should be "an inundated area"_, at least according to the english wiki page. So that would imply a watery ground, not a meadow.

The differences may be hard to understand and memorize for the layman, but I'm starting to think we have a good set of tags that do each describe a certain feature quite well. Of course, a lot of data may be tagged with the wrong kind of wetland at the moment.

Edit: maybe the combination of natural=wetland with a landuse=meadow/forest/etc was once done because there were no detailed wetland=x tags?

matkoniecz commented 10 years ago

wetland=wet_meadow still should be tagged also as landuse=meadow I endcountered many wetland + forest that was not yet mangrove or swamp (especially really small ones)

malcolmh commented 10 years ago

This ticket is about rendering, not tagging! Perhaps you could have this discussion in the tagging mailing list?

EdLoach commented 9 years ago

I had hopes that the v2.25 release announcement meant that this ticket might have been addressed. Is the surface tag not available currently? The new wetland pattern on the correct background for the tidalflat surface (mud/sand) would look quite good I think.

matthijsmelissen commented 9 years ago

The surface and wetland tags are available, but we haven't had time to implement the details mentioned in this issue.