search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.54k stars 823 forks source link

Add rendering for playground=sandpit #3884

Closed carstenhag closed 5 years ago

carstenhag commented 5 years ago

Expected behavior

Sandpit area renders a bright brownish area

Actual behavior

It doesn't show up at all.

Links and screenshots illustrating the problem

https://www.openstreetmap.org/edit#map=19/48.27879/10.97427

https://www.openstreetmap.org/way/721297176

polarbearing commented 5 years ago

Related to the request in #3885, in #3230 rendering sandpit as sand was rejected.

carstenhag commented 5 years ago

3230 was closed because the author does not continue to work on it, as far as I understood the close notice?

Even if playground equip is not rendered as >icons<, I find it silly that table tennis does render but a big sandpit isn't.

polarbearing commented 5 years ago

How is table tennis rendered??

carstenhag commented 5 years ago

It's just beneath the sandpit. Bottom left on my crappy screenshot:

Screenshot_20190912-230008

polarbearing commented 5 years ago

It is leisure=pitch that renders here, not sport=table_tennis.

Adamant36 commented 5 years ago

Could just render it as a yellow area or something similar that shows it's there but not give it the sand pattern. Of course rendering sandpits shouldn't be done in isolation of the broader question of rendering other playground equipment IMHO.

jeisenbe commented 5 years ago

PR #3230 was specifically about rendering playground=sandpit the same as natural=sand - this was not considered a good idea, because sand boxes in playground are quite different in purpose and function than most areas of sand which are tagged natural=sand

Do you have a different idea for rendering these features?

Consider that beach volleyball courts, with a sand surface, are rendered the same as concrete basketball courts and grass soccer pitches - we render by function and purpose, not by surface type.

As with golf=bunker which goes along with other golf= features, playground=sandpit would need to be rendered along with other playground= features.

This may prove difficult; a PR was previously attempted, but it was hard to find a generic playground icon to replace the current see-saw icon, which looks like a specific equipment type: https://github.com/gravitystorm/openstreetmap-carto/pull/3161

matkoniecz commented 5 years ago

Closing due to no reply to

Do you have a different idea for rendering these features?

I am not fundamentally opposed to idea of rendering this structure but I am very, very, very dubious about adding yet another new icon and even more dubious that there is some reasonable area rendering.

And missing sandpits are not a major issue.