Outline of landuse=quarry and highway=pedestrian areas look like barriers

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS

Other

1.51k stars 813 forks source link

Outline of landuse=quarry and highway=pedestrian areas look like barriers #3976

Open jeisenbe opened 4 years ago

jeisenbe commented 4 years ago

Expected behavior

Outlines of landcover area features should be subtle, just visible enough to show when two similar areas meet
The casing of highway areas should be clear enough to define the area and closely match the linear highway rendering, BUT
Outlines and casings of areas should not look like barriers such as fences or walls

Actual behavior

The dark outline of landuse=quarry areas looks too similar to a fence or wall, as mentioned in https://github.com/gravitystorm/openstreetmap-carto/issues/3974#issuecomment-554740152
The quarry outline starts at a lower zoom level than most area outlines.
Also highway=pedestrian areas have a strong outline which can be confused with barriers

Test images illustrating the problem

z19 gardens and fountain next to a pedestrian area - but it looks like they are surrounded by fences or walls z19-kennedy-gardens-fountain-before

z17 quarry by quarry (test) z17-quarry-by-quarry

Adamant36 commented 4 years ago

Well I agree that both of these things are issues, less so with highway=pedestrian though, they would be better as two separate issues IMO, but I still appreciate you opening this. My personal opinion on quarry borders is that they should be removed. I'm not to sure on highway=pedestrian.

Prince-Kassad commented 4 years ago

highway=pedestrian areas are synced with highway=pedestrian ways which have the same heavy border at the edges. Can't change one without changing the other.

nickvet419 commented 4 years ago

I looks like that because fences and walls should be rendered differently than a thin single line to differentiate themselves differently than an area boarder. This issue is also related to the derendering of barrier=kerb and others https://github.com/gravitystorm/openstreetmap-carto/pull/3969 https://github.com/gravitystorm/openstreetmap-carto/issues/3714 https://github.com/gravitystorm/openstreetmap-carto/issues/3975

jeisenbe commented 4 years ago

I believe we can fix this for quarries by changing the quarry outline color from gray to darken(@quarry, 10%):

z16 Slate quarries in Wales - current https://www.openstreetmap.org/#map=16/53.1243/-4.1475.png

Note that there is a wall or fence which comes right up to the border between the quarries, but stops there. It appears to be the same color as the quarry outline right now. There are some parts of the quarry outline that also have a wall or fence in that position.

z16 after - 10% darkened @quarry color outline

Now the quarry outline is clearly lighter than the barrier

z18 current

z18 after

This should also make it easier to adapt the style or change the quarry color in the future (though it is always a good idea to adjust the darken percentage if the fill color is lighter or darker than before)

I also tested darken(@quarry, 15%) and darken(@quarry, 20%) but these look too similar to the linear barrier rendering.

kocio-pl commented 4 years ago

That sounds resonable to me.