gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

Wetland pattern is shown too soon #4071

Open jeisenbe opened 4 years ago

jeisenbe commented 4 years ago

Expected behavior

Actual behavior

Recommended solution

Links and screenshots illustrating the problem

z6 - https://www.openstreetmap.org/#map=6/-4.741/139.164

z8 - rivers and tidal channels paths are obscured by the strong pattern export-26

z10 - some of the small rivers and tidal channels are still hard to follow, but the large ones are at least clear at this zoom level. export-21

jeisenbe commented 4 years ago

See also the tiny blue dashes created by the small* wetland areas in Latvia. These sometimes appear and then disappear at the next zoom level, since the pattern has wide gaps:

*(Actually, the wetland areas are pretty large since they are at least a few pixels at this zoom level, but too small for the pattern to be clearly seen)

z5 current Current (32 pixel area limit for water, 0.01 pixel are limit for landcover, e.g. woodland)

z5-latvia-master-water-filtering

z6 current z6-latvia-master-filtered-32pixels

z7 current

z7-latvia-master-water-filtering

z7 current 3x export SE Latvia (lots of wetlands): Current - 3x export, SE Latvia z7-latvia-export-3x-master-water-filtering

As mentioned in #4067, it is strange to show a 1 pixel area of wetland, but only show >32 pixel areas of natural=water. (See the northwest side of z6 for an area where a rather large lake is missing, but 2 smaller wetlands above and below are indicated with part of a blue dash)

kocio-pl commented 4 years ago

I think moving them later makes sense, but "4 or 5 zoom levels later than the fill color" sounds to me like way too much.

jeisenbe commented 4 years ago

z10 is 5 zoom levels later than z5, which is where the fill color is shown. That is also the zoom level where we used to render wetland patterns. It would still be 3 zoom levels sooner than any other pattern.

I'm willing to consider z9 for wetlands - that's still one zoom level later than rivers are shown. But z8 does not work well for areas near the equator, especially since small rivers are just appearing then.

To show wetlands at z8 we would need to use a very different pattern which was much finer at z8/z9: perhaps much shorter and thinner lines, closer together. That might be possible with 2x "retina" tiles but not with the current standard-resolution rendering.

imagico commented 4 years ago

z10 is IMO a good starting zoom levels for the wetland pattern. I considered that for the ac-style and came to the same conclusion.

Note the largest continuous wetland areas are tidalflats and these are rendered with a color fill from z9 - originally this was specifically meant to have these being shown one zoom level earlier in a non-obtrusive form. Now the wetland pattern starts at z5 and the fill is added at z9 which looks just weird.

Redesigning the wetland pattern would be something worth considering - the current design is mostly inspired by the German tradition but there are other styles that might be worth exploring. But in any case it is unlikely that a pattern would be suitable for display at z<10.