search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

render man_made=windpump #4149

Open sylvain-m opened 4 years ago

sylvain-m commented 4 years ago

I've just mapped a pumping windmill, and I realize that these objects are not rendered by OSM : https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dwindpump It's not very important, but it's a shame: these elements are important landmarks in the landscape. The symbol used for conventional wind turbines could be used.

If someone ever has time to do it, or to tell me where to try to make the modification (I don't know much about Github and Pull Requests)

sylvain-m commented 4 years ago

Sorry, I just saw that there were very few of these items in OSM. https://taginfo.openstreetmap.org/tags/man_made=windpump#overview I'll understand if rendering is not a priority (although I think these objects are under-mapped even though they represent landmarks)

Kovoschiz commented 4 years ago

Off-topic: You can go somewhere else discuss man_made=windpump as compared to (representing it as a) "wind turbine" (power=generator + generator:source=wind), that are used to power a pump. Cf https://wiki.openstreetmap.org/wiki/Talk:Proposed_features/Pumping_proposal, where the proposer decides to not touch it; and man_made=windmill is similarly questioned in https://wiki.openstreetmap.org/wiki/Talk:Tag:man_made%3Dwindmill#Traditional.3F, as to what the tag and "windmill" refers to.

mboeringa commented 4 years ago

Off-topic: You can go somewhere else discuss man_made=windpump as compared to (representing it as a) "wind turbine" (power=generator + generator:source=wind), that are used to power a pump. Cf https://wiki.openstreetmap.org/wiki/Talk:Proposed_features/Pumping_proposal, where the proposer decides to not touch it; and man_made=windmill is similarly questioned in https://wiki.openstreetmap.org/wiki/Talk:Tag:man_made%3Dwindmill#Traditional.3F, as to what the tag and "windmill" refers to.

I think there is no real reason to discuss this, all three tags are well established and have a clearly different meaning. Neither traditional historic windmills nor windpumps produce electric power, they use mechanical energy directly, so they have nothing to do with the "power=x" key, which essentially always involves generators doing an energy conversion. Also, construction wise, they are totally different of course.

jeisenbe commented 4 years ago

This tag has been used less than 1000 times, although this is a quite common feature in some places. I would be in favor of rendering it at some point, but perhaps we should wait until it becomes more established.

https://taghistory.raifer.tech/#***/man_made/windpump

To encourage use of this tag, you can ask on the Tagging mailing list about adding it to the Map Features page on the wiki.

Also check if this tag has a preset in commonly-used editors like iD and JOSM: this is more important than rendering in this style.

imagico commented 4 years ago

Related to #1224

BertMule commented 5 months ago

I support the request to render this. Even if it is just as a 'windmill'. Please do not force us to model it as a windmill ourselves, and loose the distiction. These are clear landmarks in the landscape and deserve to be rendered. Example here.

Pity this is already open since 2020, which is 4 years now.