search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.52k stars 813 forks source link

landuse=religious rendering too dark & fails to render name #4214

Open Thorwynn opened 3 years ago

Thorwynn commented 3 years ago

Expected behavior

Lighter color & name rendered Maybe a different color might be better?

Actual behavior

Color is dark gray and so lacks contrast with buildings & the name of the area is not rendered

Links and screenshots illustrating the problem

https://www.openstreetmap.org/way/29695256 image

Thorwynn commented 3 years ago

Looks like this was addressed once before in https://github.com/gravitystorm/openstreetmap-carto/pull/3493 If that fixed the name being rendered it seems to have broken again. I don't think I have seen shades of lavender on the map so I made a mockup with other common elements pasted in to see how that would look: image

polarbearing commented 3 years ago

I checked other examples of landuse=religious having name=*, and indeed the only ones showing names were cases when they were tagged as building=* as well.

Here is an example that has no other objects inside, so it is not a blocking issue. https://www.openstreetmap.org/way/641490956

The lavender colour however is unsuitable from my perspective, the grey was intentional to work well with residential landuse.

jeisenbe commented 3 years ago

I’m sorry that I missed this in #3493 - it appears the problem already existed before that PR.

The problem is in project.mml, where religious is only selected as a value for landuse in the landcover layer, but not in the amenity-points and text layers, unlike the similar feature amenity=place_of_worship

(Actually, this might have been introduced by #3712)