gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.55k stars 822 forks source link

Wrong placement of roads-text-name and roads-text-ref #4436

Closed alfmarcua closed 3 years ago

alfmarcua commented 3 years ago

Expected behavior

After clone of the master branch and performed an import of data of the center of Italy. Roads labels should not collide neither between them or with its shields.

Actual behavior

I have observed that there are collisions between roads and roads' shields and between the roads itself. The test was made in a docker deployment with Kosmtic. I have also tested some releases (v5.3.1, v5.3.0, v5.2.0 and v4.25.0) with the same output.

Links and screenshots illustrating the problem

Kosmtik comparison view:

road-shield

After hiding the layer roads-text-ref collision between roads can be observed:

road-road

alfmarcua commented 3 years ago

I do not know if the reason could relay in the scope of the data. Maybe by taking a small region instead of the whole world, labels are moved and those errors appear.

imagico commented 3 years ago

I have troubles parsing your problem description. The place you are referring to is:

https://www.openstreetmap.org/#map=16/43.6121/13.4127

I see nothing wrong there beyond the problems already documented in #951 and #4401.

If you are concerned about the rendering results in kosmtik differing somewhat from those on osm.org - that is due to kosmtik rendering much smaller metatiles and therefore metatile edge errors being more frequently observed. Turning on the tile grid display in kosmtik will help you see where this is the case.

The issues with labels at tile edges is a problem that is generally hard to solve in map rendering and within the limits of our rendering framework and the constraints of a real time map that is not really feasible.

alfmarcua commented 3 years ago

Exactly, it is due to metatile edge errors in Kosmtic. Thank you so much for your detail answer.

kosmtic-grid