gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

Differentiate power=generator and power=plant rendering #4543

Open Adamant36 opened 2 years ago

Adamant36 commented 2 years ago

The way solar panels are currently rendered makes them look fences when they are mapped individually as part of a solar farm since they both have render as the same color. Either one of them should be rendered differently or the border color currently around solar panels that are mapped as areas should be.

https://www.openstreetmap.org/#map=18/39.78338/-122.14040 Solar panels in solar farm

HolgerJeromin commented 2 years ago

To save some clicks: The outer one has: power=plant. The inner have: power=generator.

Adamant36 commented 2 years ago

To save some clicks: The outer one has: power=plant. The inner have: power=generator.

I probably should have check ahead of time, but I assume they are tagged with whatever the defaults in Id Editor are.

jdhoek commented 2 years ago

Something like a slightly darker area colour for power=generator? Would that cause collateral damage in other uses of power=*?

Example of current rendering for a larger plant:

Screenshot from 2022-05-24 15-15-23

Adamant36 commented 2 years ago

Something like a slightly darker area colour for power=generator? Would that cause collateral damage in other uses of power=*?

That would be one solution. On Open Infrastructure Map they are rendered dark purple. Maybe something along those lines or your suggestion would work. I don't there's much room to change the color of the border. Not that there are a lot of options when it comes to changing the fill color either though.

Open Infrastructure Map

jeisenbe commented 1 year ago

Updating title to clarify that this issue is suggesting a distinct rendering for power=generator as opposed to power=plant.

The history is that power=generator used to be tagged on a whole area of a power station / plant: see https://wiki.openstreetmap.org/wiki/Tag:power=generator?uselang=en - "This tag was historically used to map whole power plants, often as an area. In 2013 the power refinement proposal introduced power=plant for such features.”

jidanni commented 1 year ago

And do add a lightning bolt symbol or something. Else these seem like parking lots or dormitories or prisons or something.

jidanni commented 1 year ago

Here users see a mysterious "Forney Energy Center". Users think "huh, no emblem, and an unclear name... I bet it is a nuclear power plant!" 20230320T114851

That is problem 1.

Problem 2 is: editors editing it think: "Good thing there is a flame icon for sites like these, so people know it is just a fossil fuel plant. 20230320T114800 Ah, but that flame is just in the (iD) editor... not in the (carto) renderer! No, not exactly "bait and switch" but still disappointing.