gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

Change color of landuse=recreation_ground to be different than `leisure=playground` or `leisure=fitness_station`, instead make same as `leisure=park` #4573

Open jeisenbe opened 2 years ago

jeisenbe commented 2 years ago

Right now landuse=recreation_ground is rendered differently than leisure=park, even though the two tags have overlapping meanings.

"An open space for general recreation, which often includes formal or informal pitches, nets and other recreation equipment or infrastructure. Often municipally owned, but sometimes also part of colleges / companies, or commercially operated. Of British origin, the term is used in many commonwealth countries.” landuse=recreation_ground -https://wiki.openstreetmap.org/wiki/Tag:landuse%3Drecreation_ground

"leisure=park - in many cases area is both recreation ground and a park. In such cases usual tagging is to add just leisure=park

"A park is an area of open space for recreational use” https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dpark

It appears the landuse=recreation_area tag is mostly British and Commonwealth for a sports-oriented type of park. But in my State, Oregon, landuse=recreation_ground is being used for tennis court areas within parks, as way to get them to render differently. E.g. https://www.openstreetmap.org/changeset/107472236

In the past we rendered leisure=recreation_ground the same as park (note the key “leisure”, not “landuse”), which made sense but supported a less common tag, and landuse=recreation_ground the same as grass/garden, which did not work well. This was changed in #2964 - but instead of keeping the rendering the same as park, landuse=recreation_ground is now rendered the same as leisure=playground and leisure=fitness_station

This is a problem because these are small areas that are often found inside of a park or recreation area, and right now they are not clearly distinguished. The wiki page picture for landuse=recreation_area shows a fitness station in a park-like environment:

Examples: https://www.openstreetmap.org/way/305534478 leisure=playground within landuse=recreation_ground

Screen Shot 2022-06-08 at 10 26 39

https://www.openstreetmap.org/way/599711381 leisure=fitness_station and leisure=playground within landuse=recreation_ground

Screen Shot 2022-06-08 at 10 33 23

Compare to these in a park where the contrast is clear: https://www.openstreetmap.org/way/737032637#map=18/51.51551/-0.02168

Screen Shot 2022-06-08 at 10 35 45

Another example: https://www.openstreetmap.org/way/923509936

imagico commented 2 years ago

The problem you are trying to address here is part of a larger complex of issues i described more in detail in https://github.com/gravitystorm/openstreetmap-carto/pull/4384#issuecomment-825551823.

It would be great if we could untangle this and get back to a systematic color design for polygon fill colors - following the basic design rules we have been discussing on various occasions - in particular that differences in color should reflect differences in purpose and meaning for the target map users. And that stronger colors should be used predominantly for small features with narrowly defined meaning while broad classifications should should use weaker colors.

BertMule commented 3 weeks ago

There is some merit.

Recreation_ground is often quite distinct. An area deliberately created, often at a waterfront, with facilities like toilets, possibly with an (atificial) beach, piers for boaters, ... That's how they are often here in the Netherlands, and which I have modelled quite a lot of.

There is some similarity with parks, though I tend to see them differently. I consider them typically to be in cities.

In any case, don't blanket either of them with grass, as the semantics get lost. Form follows function. This applies to a lot of other areas, like camping grounds, sports-areas, ...