gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.55k stars 822 forks source link

Theme park outline not rendering correctly over highway areas #4682

Closed wmisener closed 2 years ago

wmisener commented 2 years ago

Expected behavior

Theme park (tourism=theme_park) and zoo (tourism=zoo) outlines should render on top of everything else, since they define a sort of boundary. This would be similar to how protected area outlines currently render.

Actual behavior

Theme park outlines appear to render below highways, but above other objects like buildings and piers, leaving to an undesirable broken outline. This is especially noticeable under pedestrian areas (highway=footway+area=yes), but appears to be true for all highway=*, whether they are mapped as ways or areas.

Screenshots with links illustrating the problem

Screen Shot 2022-09-11 at 11 11 50 AM

https://www.openstreetmap.org/way/173532595, Pacific Park, Santa Monica, CA, USA

Screen Shot 2022-09-11 at 11 13 15 AM

https://www.openstreetmap.org/#map=19/33.80960/-117.91858, Disneyland, Anaheim, CA, USA

Screen Shot 2022-09-11 at 11 17 33 AM

https://www.openstreetmap.org/#map=19/33.80960/-117.91858, Universal Studios, Los Angeles, CA, USA

Compare:

Screen Shot 2022-09-11 at 11 21 45 AM

https://www.openstreetmap.org/#map=19/33.80960/-117.91858, Circle X Ranch, Thousand Oaks, CA, USA

Notice how the protected area boundary goes on top of the roadways. I find this desirable behavior, though it's been proposed to change it in #4127, due to rendering issues with closely parallel boundaries (#3685)

imagico commented 2 years ago

This is in principle easy to fix by moving the tourism-boundary layer above the road layers.

Note however your examples also illustrate how problematic this kind of rendering is and how severely it affects map readability, in particular in cases where the outline of a theme park/zoo intersects something like a pedestrian area.

wmisener commented 2 years ago

I'm not sure I understand, by "how problematic this kind of rendering is" do you mean the current rendering, with the boundary under the pedestrian areas, or my suggestion, which would put the boundary above the pedestrian areas? If you mean the suggestion, could you clarify how you see the posted examples, which are all of the current rendering, illustrating this? Or, do you mean the style of rendering boundaries with a line and casing in general?

I see these examples as depicting how the current rendering of these boundaries underneath the pedestrian areas is very bad for map readability. Especially the first one at Pacific Park, which is how I noticed it in the first place. It's not clear to me whether your comment is in support of or in opposition to the suggested change, or about a broader stylistic question.

imagico commented 2 years ago

do you mean the current rendering, with the boundary under the pedestrian areas, or my suggestion, which would put the boundary above the pedestrian areas?

Sorry if i was unclear - i was referring to the design concept for rendering these features in general, independent of the position in the layer stack.

If you take that design as a given your suggestion is perfectly fine.