gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 817 forks source link

Add rendering icon for craft=luthier #4777

Open sylvain-m opened 1 year ago

sylvain-m commented 1 year ago

Even if this tag (craft=luthier) is not very widespread (about a hundred POIs), it would be interesting to represent luthiers by a stringed instrument icon (violin or guitar for example).

https://taginfo.openstreetmap.org/tags/craft=luthier https://en.wikipedia.org/wiki/Luthier

sylvain-m commented 1 year ago

If this use is too rare [*], one could also group the display with craft=musical_instrument, or even with shop=musical_instrument. As a minimum, a dot should be displayed, and with the name of the workshop at the most important zooms.

https://taginfo.openstreetmap.org/tags/craft=musical_instrument https://taginfo.openstreetmap.org/tags/shop=musical_instrument

[*] I don't know how many occurrences are required to select a particular icon.

imagico commented 1 year ago

Thanks for the suggestion

craft=luthier has 103 uses, almost exclusively in western Europe craft=musical_instrument has 168 uses with only slightly wider distribution.

We so far lack a sustainable overall design concept of rendering crafts in this style - see #1697.

sylvain-m commented 1 year ago

Thanks for the link to this issue, and indeed I notice that the rendering of the whole craft=* is missing... I understand that the problem is much larger (and therefore complicated)

I hope that this issue will progress, because crafts POI deserve to appear on a general public map, at least by their name and a generic dot.

kontrarie commented 1 year ago

I should like to disagree with the suggestion to tag them as shop= : most shops will only sell; whereas a luthier is basically a builder of instriments, though she/he will usually do the "sales part": as far as I have observed, the vast majority are one-person enterprises. OTOH I would support the more generic craft=musical+instrument, given the scarcity.