search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.55k stars 822 forks source link

golf=pin in rendered on nodes and polygons but is only used on nodes #4862

Open imagico opened 1 year ago

imagico commented 1 year ago

For mapper feedback it would be good to remove rendering of golf=pin on polygons. This is currently not used at all so it is not constructive for us to render.

Just requires adding a way_area IS NULL condition in SQL.

benjaco commented 1 year ago

Could not find any guidance to test cases where it issn't in the OSM dataset, how do you normally go about testing such things?

imagico commented 1 year ago

You can create a test case in JOSM, run it through osmium renumber and import it into your test database.

Alternatively you can also edit your test database - for example something like:

UPDATE planet_osm_polygon SET tags = tags || '"golf"=>"pin"'::hstore WHERE osm_id = 12345;