render barrier=planter - Githubissues

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS

Other

1.55k stars 822 forks source link

render barrier=planter #4867

Closed ntzm closed 1 year ago

ntzm commented 1 year ago

Fixes #4751

Changes proposed in this pull request:

Render barrier=planter in the same style as barrier=bollard/log/block/turnstile

Test rendering with links to the example places:

https://www.openstreetmap.org/node/1084062161

Before

After

imagico commented 1 year ago

Thanks for the pull request, technically it looks fine.

However, as pointed out in #4751 man_made=planter is much more widely used for mapping planters and barrier=planter is not consistently used only for planters serving as barriers on roads in a similar fashion as barrier=gate. Hence i think it would be preferable to render man_made=planter.

imagico commented 1 year ago

Closing this for the reasons mentioned. I encourage you to look into #4868 and discuss ideas how to render man_made=planter there if that is of interest for you. The tag is not used in very large numbers but use is consistent and geographically broad so personally i would be in favor of this if a suitable intuitively understandable design can be developed.