Fix rendering of highway=track that was broken in PR #4666

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS

Other

1.51k stars 811 forks source link

Fix rendering of highway=track that was broken in PR #4666 #4895

Closed MeonStudios closed 7 months ago

MeonStudios commented 8 months ago

Fixes #4881

This PR has no new features but a bugfix:

highway=track is fixed and again rendered like it is in the current release
roller_coaster=track has no visual changes

Examples

Before

highway=track is rendered like it is a roller coast track

After

highway=track is rendered correctly again

Before

roller_coaster=track is rendered

After

roller_coaster=track is still rendered the same way, no visual changes

pnorman commented 8 months ago

cc @tjur0, if you could also review it.

MeonStudios commented 7 months ago

Anything needed from my side before we can merge this?

MeonStudios commented 7 months ago

Great thanks for taking the time to check! Are there any other blocking issues for a (potential) release? Then I know what I will pick up next.

imagico commented 7 months ago

I opened #4900 to discuss the next release. There is nothing really blocking it. I also created #4901 aiming to list the most important issues of the style currently and what state they are in. Note, however, that these are not really recommendations what to work on as a developer, they are more strategic issues where working on a consensus direction is required.

Generally speaking work on bug fixes and improvements of existing features is more important that feature additions. In particular desirable IMO are feature removals - though these also tend to attract loud opposition - which can be unpleasant.