gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.51k stars 811 forks source link

Inconsistent rendering of generic taggings in case of catch-alls (shop=yes, office=yes) #4906

Open imagico opened 7 months ago

imagico commented 7 months ago

We currently have a number of catch-all renderings in the style were we depict features with a certain key independent of the value. That in particular

for building and office we do this for the value yes like for any other value while for shop we explicitly exclude shop=yes. In all three cases the yes is broadly accepted as valid tagging if a more specific classification is not available to the mapper.

IMO we should:

For building=yes i would not suggest a special treatment because it is so widely used without being broadly considered to be lacking more specific information.

See also #4723.

dch0ph commented 7 months ago

Above sounds reasonable.

182k shop=yes and 80k office=yes. In both cases about 70% have names.

Possible suggestions for rendering that would hint to both map user and mappers that data is incomplete:

  1. Use a lighter shade of shop / office colour for dot and any name. Using a lightened colour rather than reduced opacity might cause less semantic confusion with private access e.g. on parking.

  2. A common grey colour (as in highway=road) for "incomplete objects". This has been suggested, but probably too jarring.

imagico commented 7 months ago

Use a lighter shade of shop / office colour for dot and any name

We already use that for access restricted POIs so it would be confusing.

A common grey colour

We already use gray dots for bollards (small) and waterway barriers (large):

https://imagico.de/map/styleinfo/#style=osmcarto&section=tags&key=barrier&value=bollard https://imagico.de/map/styleinfo/#style=osmcarto&section=tags&key=waterway&value=lock_gate