Open Dimitar5555 opened 6 months ago
Thanks for looking at the waste icons. These indeed could use some refinement work.
I don't quite understand your critique and suggestion though. Here current symbols we use and the maki waste basket symbol mentioned in comparison:
amenity=waste_disposal
(not to mention a very crowded map in areas with many waste baskets). And there is no substantial room to increase the size of the amenity=waste_disposal
symbol within our 14x14 pixel standard (shown in the illustration).Agree with the general point that amenity=waste_disposal
is poorly differentiated from amenity=waste_basket
, as the example shows.
From a brief look, it is not straightforward to simply re-use the font awesome icons as iD does. iD can and does use larger icons (16 x 16?) for a start.
A simplified version of the font awesome "dumpster" might work. Wide rather than tall would visually differentiate from waste_basket
and a simple flat lid with no handle (avoiding the perspective aspect)?
Personally I don't think the maki wastebasket looks good. It looks like a cup with a generous cappuccino! The FA symbol is more recognisable.
I don't quite understand your critique and suggestion though.
For waste baskets we use a tiny pot and for dumpsters we use a waste basket. The easiest solution seems be to use the current icon for waste_collection
on waste_basket
and think of another icon for the dumpsters.
A simplified version of the font awesome "dumpster" might work. Wide rather than tall would visually differentiate from waste_basket and a simple flat lid with no handle (avoiding the perspective aspect)?
I've tried to draw a dumpster but it's 16x16. 14x14 doesn't seem to work like I want it to:
Expected behavior
amenity=waste_disposal
should be rendered with something similar to a dumpster/large container.amenity=waste_basket
should be rendered with something that looks like a waste basket.Actual behavior
Currently
amenity=waste_disposal
is rendered with the same icon asamenity=waste_basket
but with minor diffrences (one of them being their size).amenity=waste_basket
is rendered using an icon that looks like a cremation pot/flower pot with a lid.iD seems to use nice icons for both of them. I'm not sure if they can be used directly but they are a good inspiration.
amenity=waste_basket
: https://github.com/mapbox/maki/blob/main/icons/waste-basket.svgamenity=waste_disposal
: https://fontawesome.com/v5/icons/dumpster?f=classic&s=solidScreenshots with links illustrating the problem
Current rendering:
iD icons:
![image](https://github.com/gravitystorm/openstreetmap-carto/assets/19364673/ff14b761-d33f-4ddb-a9b5-6f47823f0dff)