gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.51k stars 811 forks source link

Why square cap for cutline? #4930

Open dch0ph opened 5 months ago

dch0ph commented 5 months ago

I can see past arguments about the width / colour of man_made=cutline, but can anybody explain the choice of a square line cap rather than the (default) butt? This leads to weird protrusions, which don't make sense cartographically:

Here: image

The butt cap is not ideal when the cutline is not perpendicular to the forest edge, but the square just looks odd at any angle. Is this a hangover from when it was a pale colour / white and the "overrun" was less visible?

imagico commented 5 months ago

This dates back to the time when cutlines were rendered in plain land color (see #1767).

With us now rendering the landcover layer at the very beginning and the cutlines immediately afterwards we could probably use comp-op to make the cutlines only show up above a defined landcover and not over plain land color. I have not actually tried this though, just an idea.

But the whole concept of rendering cutlines in a way that implies a specific landcover is also questionable in principle.