Use common Single Quotes for Strings

MaikBusch78 commented 3 months ago

Fixes NO issue, just cosmetic change

Changes proposed in this pull request:

Use single quoting for String constants

Test rendering with links to the example places:

tested with carto; the generated project.xml files before and after are identical

pnorman commented 3 months ago

Rendering should not be influenced by this cosmetic change

Have you tested this?

MaikBusch78 commented 3 months ago

Rendering should not be influenced by this cosmetic change

Have you tested this?

No

MaikBusch78 commented 3 months ago

Ok, i have tested it now by calling carto project.mml > project.xml.{number} on the original and on the changed quotes for string values version. Changing only the quotes from double to single the result is exactly the same (md5sum). To be sure that my changes have been reflected in the result i also tested to change the values. Changing entrance values from main to mainx resulted in many many changes in the xml. Changing leaf_type from leafless to leaflessx resulted in only a single line change. From my understanding how the style is used, i believe that this kind of test is good enough.

MaikBusch78 commented 3 months ago

I have also updated the coding guidelines.

MaikBusch78 commented 3 months ago

@imagico I have seen now, you are also a maintainer. So i may ask you, what is left to do to make this PR merged?

gravitystorm / openstreetmap-carto

Use common Single Quotes for Strings #4939