search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.51k stars 811 forks source link

Releasing v5.9.0 #4981

Open imagico opened 2 weeks ago

imagico commented 2 weeks ago

5.8.0 is more than half a year ago so i think it would be good to think about a new release.

So far we have only few rendering relevant changes merged:

but we have two pending pull requests that are IMO ready to be merged and that would be good to include if we decide to accept them:

Especially the first would be an important change (it addresses most of our second oldest open issue - #214 - and represents a major change in our paradigm of interpretation of tagging). And since both are making somewhat extensive modifications to the road layers it would be good to not to have these pending for too long to avoid larger merge conflicts. These are currently pending review by @pnorman (who had requested changes) and potentially further consensus building among the maintainers. Help/input from the other less active maintainers would be welcome.

I would leave #4978 for after the next release since we still need to discuss how exactly we want to proceed with that (when we move to make it mandatory to use the flex backend that would mean a new major version).

pnorman commented 2 weeks ago

I did a review access tags. I really want to get away from the messy incorrect way we currently handle access tags, but I think there are substantial technical changes needed.

dch0ph commented 1 week ago

Is it worth reconsidering #3012 ? I'm not an expert in Github actions, but I think it would now be feasible to include the XML produced in the CI testing as an artifact? This would significantly simplify installation.

imagico commented 1 week ago

3012 has been waiting for someone to develop a practical solution since 2018. I think it would be nice to solve this but i don't see a particular need for it now for this release.

pnorman commented 1 week ago

I see no relation between #3012 and this release. Someone can develop the github actions that saves artifacts if they want and it'll start running immediately without waiting for a release.

Also we would generally not wait for an issue to be resolved that doesn't at least have a PR!

dch0ph commented 1 week ago

I see no relation between #3012 and this release

The only connection in mind was that releases can be bundled with artifacts, such as the carto.xml. But if people can run an action more generally to generate a carto.xml for any commit point, that would be even more useful.

Also we would generally not wait for an issue to be resolved that doesn't at least have a PR!

Indeed, but knowing that a PR would be both welcome and feasible might inspire a contribution!

imagico commented 1 week ago

The only connection in mind was that releases can be bundled with artifacts

For us releases so far are just tags in git - see https://github.com/gravitystorm/openstreetmap-carto/blob/master/RELEASES.md

Indeed, but knowing that a PR would be both welcome and feasible might inspire a contribution!

Yes, #3012 is open and we'd welcome a solution for it. Some comments have been provided what methods for implementing that might be feasible and what are not but i'd suggest anyone who wants to work on that to discuss their planned approach before investing work in implementation.