search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.55k stars 822 forks source link

Releasing v5.9.0 #4981

Closed imagico closed 1 month ago

imagico commented 5 months ago

5.8.0 is more than half a year ago so i think it would be good to think about a new release.

So far we have only few rendering relevant changes merged:

but we have two pending pull requests that are IMO ready to be merged and that would be good to include if we decide to accept them:

Especially the first would be an important change (it addresses most of our second oldest open issue - #214 - and represents a major change in our paradigm of interpretation of tagging). And since both are making somewhat extensive modifications to the road layers it would be good to not to have these pending for too long to avoid larger merge conflicts. These are currently pending review by @pnorman (who had requested changes) and potentially further consensus building among the maintainers. Help/input from the other less active maintainers would be welcome.

I would leave #4978 for after the next release since we still need to discuss how exactly we want to proceed with that (when we move to make it mandatory to use the flex backend that would mean a new major version).

pnorman commented 5 months ago

I did a review access tags. I really want to get away from the messy incorrect way we currently handle access tags, but I think there are substantial technical changes needed.

dch0ph commented 5 months ago

Is it worth reconsidering #3012 ? I'm not an expert in Github actions, but I think it would now be feasible to include the XML produced in the CI testing as an artifact? This would significantly simplify installation.

imagico commented 5 months ago

3012 has been waiting for someone to develop a practical solution since 2018. I think it would be nice to solve this but i don't see a particular need for it now for this release.

pnorman commented 5 months ago

I see no relation between #3012 and this release. Someone can develop the github actions that saves artifacts if they want and it'll start running immediately without waiting for a release.

Also we would generally not wait for an issue to be resolved that doesn't at least have a PR!

dch0ph commented 5 months ago

I see no relation between #3012 and this release

The only connection in mind was that releases can be bundled with artifacts, such as the carto.xml. But if people can run an action more generally to generate a carto.xml for any commit point, that would be even more useful.

Also we would generally not wait for an issue to be resolved that doesn't at least have a PR!

Indeed, but knowing that a PR would be both welcome and feasible might inspire a contribution!

imagico commented 5 months ago

The only connection in mind was that releases can be bundled with artifacts

For us releases so far are just tags in git - see https://github.com/gravitystorm/openstreetmap-carto/blob/master/RELEASES.md

Indeed, but knowing that a PR would be both welcome and feasible might inspire a contribution!

Yes, #3012 is open and we'd welcome a solution for it. Some comments have been provided what methods for implementing that might be feasible and what are not but i'd suggest anyone who wants to work on that to discuss their planned approach before investing work in implementation.

imagico commented 4 months ago

Regarding https://github.com/gravitystorm/openstreetmap-carto/pull/4952#issuecomment-2224350931:

My strong preference would be to release 5.9.0, merge the flex PR, make the necessary column changes and normalization at import time, and then merge the style changes for being part of 6.0.0

I have explained above why i consider #4952 to have priority.

Frankly, if we cannot come to a consensus on an approach to addressing #214 given the admirable work @dch0ph has invested i see no point really in merging #4978. #4978 is a means to the end of improving our capabilities in map design, not an end on its own.

If you would like changes to #4952 that depend on #4978 lets discuss those, work on consensus on that and then plan the releases accordingly.

imagico commented 1 month ago

With #4952 merged i intend to prepare the release soon. I merged #4996 to be included in the release as well.

My current perspective for after the release is to

  1. concentrate on merging #4978.
  2. discuss and agree on potential database schema changes to be included in the next major version (which is going to be needed with #4978). That in particular refers to discussing if to remove the columns for foot/bicycle/horse as mentioned in #4952.
  3. make a new major release.

Also we can think of follow-up changes to #4952 (like #4321, #4998, #1321, possibly a comprehensive solution for bus exclusive roads).

imagico commented 1 month ago

v5.9.0 is released: