gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.51k stars 811 forks source link

support `landuse=civic_admin` and related `landuse` #4983

Open alexlancaster opened 6 days ago

alexlancaster commented 6 days ago

This PR supports the landuse=civic_admin tag by rendering using a light blue background using the same styling as the Tracestack Topo layer

Fixes #2985

Changes proposed in this pull request:

Test rendering using local Kosmtik docker container:

imagico commented 6 days ago

Thanks for the pull request.

This change suggests to render the following tags in a unified design with a semi-transparent blue-green fill and a matching thick outline, similar to the ones used for marinas/theme parks but rendered in the landcover layer:

I see a number of issues with that:

The tags suggested to be rendered are IMO not suitable to be rendered in this style at this time. Specifically:

All four tags massively overlap in their meaning and we have the general principle not to introduce new rendering of synonyms in this style. As the documentation of landuse=commercial correctly states, mappers widely use this tag also for government/administrative areas. There is no consensus that using any of the above tags instead is a more desirable way of tagging.

In terms of rendering it is also significant to note that office=government (263k uses) - with a further differentiation tag government=* (115k uses) - is the more widespread (and more broadly accepted) way to map specifics about administrative infrastructure. Rendering such in a differentiated form would be more significant for us. Also keep in mind that much administrative infrastructure is building-only with no area outside the building being part of a specific land use. Such cases would not show up with landuse rendering and such rendering could incentivize mappers to draw arbitrary wrapper polygons for the visual effect.

Regarding the design proposed - independent of the tagging this has the following issues:

Bottom line: I don't think any of the suggested tags currently qualifies for being rendered here and especially not all of them together as synonyms. And if, at one point in the future, this changes we would need to choose a design that harmonically integrates with our existing urban landuse rendering.

Side note: The rendering sample does not seem to match the current mapping - the polygon with the landuse tagging is this: https://www.openstreetmap.org/way/814380638 and i don't see the origin of the inner yard outlining shown.