gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.55k stars 822 forks source link

Rendering Man Made #5000

Closed KillerKingSolo closed 3 months ago

KillerKingSolo commented 3 months ago

man_made Does not render on OSM or other programs without being in the edit mode. This would be very useful for stuff like mineshaft, adit, storage_tank, tower, and other man_made stuff. I know of some places that don’t actually renter the man_made stuff and I can’t save it as a waypoint or anything like that on Organic Maps because it’s not rendering so I have to make my own waypoint and not have the actual name save place of the man_made location.

Examples: https://www.openstreetmap.org/#map=19/34.35652/-117.74442 https://www.openstreetmap.org/#map=19/34.36081/-117.74441

image image image image

HolgerJeromin commented 3 months ago

We decide rendering per key=value and not per key=* (with exception building=, shop=). See existing discussion #3704, #4868, #4149, #3967

imagico commented 3 months ago

As far as rendering any and all values of man_made=* in a uniform design is concerned - we quite definitely don't want to do that, we render tags, not keys - with very few specific exceptions (buildings, shops, offices)

Apart from that

I am closing this - as duplicate for man_made=adit, as invalid for man_made=storage_tank and man_made=tower and as wontfix for a catch-all on man_made=*. man_made=mineshaft can be looked at if the tagging practice becomes more consistent, possibly together with man_made=adit and other mining related tags - see https://github.com/gravitystorm/openstreetmap-carto/issues/3704#issuecomment-517826560.

@HolgerJeromin - as far as open issues on man_made=* are concerned - there is in particular also #3494 and #1224. The latter IMO being one of the most serious gaps in our style as far as POIs are concerned. Help on this and any of the other open issues mentioned would be welcome.

KillerKingSolo commented 3 months ago

But why can't I see it on open street map. I have to be in edit mode to see it. I can't view it in non-edit mode.

imagico commented 3 months ago

The two locations you linked to have features tagged man_made=adit - which, as explained, we currently do not render, we already have a distinct open issue for that (#3704).