search

gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.55k stars 822 forks source link

Render generic industrial with a dot and a name #5017

Open GeeKaa71 opened 2 months ago

GeeKaa71 commented 2 months ago

I feel that an industrial location should be rendered with a dot and a name, just like it is done with office= and shop=.

Currently the next node is not rendered at all... industrial=construction_company name=Timmerfabriek Brand

imagico commented 2 months ago

Thank you for your suggestion.

industrial=* is primarily used at the moment as a secondary tag to further characterize features with a primary tag landuse=* or man_made=*. Standalone use exists, but is not well established - see also https://wiki.openstreetmap.org/wiki/Talk:Key:industrial. industrial=construction_company is documented exclusively for such use. Use as a primary tag would also blur the boundary between e.g. a construction company office (office=construction_company, 2.7k uses) and an industrial production site.

We also want to avoid introducing new catch-alls since this is counterproductive for mapping feedback, see #5014 and issues referenced there.

We could think about better differentiating landuse=industrial and man_made=works based on secondary tagging with industrial=* .

industrial=construction_company specifically has 310 uses.

GeeKaa71 commented 2 months ago

Ok, I get it... as I see it (but correct me if I'm wrong)... There can be buildings with an industrial destination, food processing companies, construction companies, machinery etc. You can of course give the building a name, but I think it's better to create nodes for the different industrial companies that are housed in the building. Here "man-made" is not really a good keyword I think. The node would then contain the name of the company, together with the address, website, type of industry etc. That should then be rendered with a dot at higher zoom levels, together with the name of the company as I suggested before...

Indeed building-company may not be used much at the moment, but industrial alone is used more than 270k times

imagico commented 2 months ago

This is not a forum to discuss what the best way is to map things. But if you want to map the offices of a construction company office=construction_company is the established way to do that. industrial=construction_company would - in combination with landuse=industrial or man_made=works - be a suitable tagging for an operational area of a construction company (like machine and material storage, workshops, production lines for pre-fabrication of components).

industrial=* on nodes is predominantly used as a secondary tag as well - mostly (about 85 percent) industrial=grinding_mill in combination with man_made=works from an organized edit/import in Tanzania.