Add rendering for amenity=clinic

[matthijsmelissen]

Jóhannes Birgir Jensson reports on the talk mailinglist:

"Also worrying that amenity=clinic still isn't displayed with the cross like pharmacy and others, in many rural places this is the only healthcare around. http://www.openstreetmap.org/node/2303511227"

[Stalfur]

That would be me. I'm thinking mostly about places like Khawa in Botswana, an isolated village in the desert far away from any other medical help http://www.openstreetmap.org/node/2865355410#map=17/-26.28094/21.36650

[matthijsmelissen]

Yes, makes sense to render it I think.

[Stalfur]

While doing that should we also add to render healthcare= tag which has enjoyed some support in moving from amenity= tag for health services?

[Stalfur]

Found a node that solved this not rendering by marking it as a hospital and then naming it Clinic. People will do many things to show up on the map. http://www.openstreetmap.org/way/243283827#map=14/-13.8517/33.8677

[pnorman]

healthcare would be out of scope for this amenity=clinic, and would be a 3.x change as it would require a DB reload.

As for why of why it isn't yet rendered, this is the first issue about this tag. The tagging around healthcare being a horrible complex mess doesn't help either.

[daganzdaanda]

See also amenity=doctors #89 We should look at the most used amenity values and see what is missing.

[ghost]

We still don't have the icon for this tag. http://taginfo.openstreetmap.org/tags/?key=amenity&value=clinic

[Stalfur]

I would use similar to current hospital, if it needs to be different remove the circle around it

[kocio-pl]

Let it be like this - or maybe the same as the hospital or the same as the amenity=doctors? I'm not sure what are key difference between such objects and having the clinics visible is probably even more important than rendering "doctors".

[Stalfur]

Amenity=doctors is now rendered. As most clinics have doctors (but not all) it seems like a easy and acceptable solution

[kocio-pl]

So what icon shape do we choose:

1. Hospital cross without the circle.
2. Doctors bag.
3. hospital cross (maybe the same as in hospital)?

According to english Wikipedia clinic may be small local facility, but "[s]ome clinics grow to be institutions as large as major hospitals, or become associated with a hospital or medical school, while retaining the name 'clinic.'" [ https://en.wikipedia.org/wiki/Clinic ]

So this can be different objects in reality (small/medium/large, independent/part of hospital), hence the difficulty with finding the right symbol.

[Stalfur]

I for one would like to see 1. Hospital ross without circle

In my area the clinic has general doctors (who refer cases onwards to specialists if needed) and nurses, while also being responsible for infant checkups and inoculation. I would only go to a hospital for a major thing.

I believe the same situation is in other less developed areas where access to a hospital is even more ardous.

[kocio-pl]

I still have no clear preference for symbol, but I think that it should be rendered form z>=16 (simply because hospital is z>=15 and doctors is z>=17).

[kocio-pl]

I made the simple cross icon at last (baby steps with Inkscape), but I don't know how should I publish it now, because GitHub doesn't accept SVG ("Unfortunately, we don't support that file type. Try again with a PNG, GIF, or JPG."). What should I do now?

[matkoniecz]

Are you trying to edit repository using online editor?

I would recommend using git client (for starting with git I used https://try.github.io/levels/1/challenges/1 and http://git-scm.com/book/en/v1/Getting-Started )

But it is possible to add SVG file using online editor.

I did this by creating a new file named test.svg and copying svg file contents there (it is just text).

[kocio-pl]

Thanks! Git is my tool of the month to learn (also for work) and I will read both git getting started guides anyway to understand it better, but is there a simple path to update my personal fork ( https://github.com/kocio-pl/openstreetmap-carto ) to latest osm-carto version and work with it?

I made this fork exactly for creating my own osm-carto patches, just because one of the guides told me to do so, but I got stuck at rendering too big data set. Now I'm trying to resume this and playing with icons is additional reason for it.

[EDIT:] OK, I managed to update my fork with this:

http://stackoverflow.com/questions/22318145/update-github-fork-from-web-only-in-other-words-without-git#22321511

Of course CLI version is also possible:

https://help.github.com/articles/syncing-a-fork/

The bottom line is I think we need more people engaged in developing osm-carto and the bar is high now, so we need some simple, task-oriented guides and tools for a start.

[kocio-pl]

That's what it is =} :

https://github.com/kocio-pl/openstreetmap-carto/blob/master/symbols/clinic.16.svg

[matkoniecz]

@kocio-pl One small thing for future: it is better to make new branches for new features. This way it is possible to work on more than one thing at the time (for example - more than one pull requests at the same time). It also makes much easier to update your fork.

web interface note: search for

branch:

to find place where it is possible to switch/create branches.

we need some simple, task-oriented guides and tools for a start.

Yes, it would be great to have something like that.

[pnorman]

https://guides.github.com/introduction/flow/ is a reasonable introduction to the github workflow we approximately use

also https://github.com/gravitystorm/openstreetmap-carto/blob/master/CONTRIBUTING.md#workflow

[kocio-pl]

Here is my PR regarding rendering icon and the area tagged as amenity=clinic:

https://github.com/gravitystorm/openstreetmap-carto/pull/1474

As I said, I think this icon should be seen from z>=16, otherwise it's just like the hospital.

[kocio-pl]

Once I got deeper into OSM icon designing, I have another idea - nothing very surprising, but I'm pretty sure it's better than a cross without a circle: - what do you think about it?