gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 819 forks source link

Residential terminating at T intersections with service roads #84

Closed pnorman closed 10 years ago

pnorman commented 11 years ago

17/20791/44884

Not the most common way for service and residential to meet, but valid tagging, and it looks odd

gravitystorm commented 11 years ago

I don't have any good ideas as to how to tackle this one - suggestions welcome.

pnorman commented 11 years ago

IRC:

11:01 < ajashton> not sure there is much that can be done without either changing all roads to line-cap: butt (which would introduce other issues) or concocting some very complex postgis queries + style rules
11:02 -!- dwins1 is now known as dwins
11:03  * pnorman is intrigued by the latter
11:04 < ajashton> basicallu, mapnik has know knowledge of any connection between the two lines, so you'd have to figure that out somehow in postgis (I have no idea how exactly)
11:05 < ajashton> then use that information to add an attribute which you could filter on and change the line-cap style for just those roads that intersect smaller ones
11:05 < pnorman> knowing the two lines intersect isn't bad, knowing that one terminates at another is harder
11:14 < pnorman> the performance implications are probably bad too
11:15 < pnorman> if it was more common you'd gain some from going to butt ends, but it's fairly rare and the SQL could be complex

It also occurs to me that this is essentially the same as #84

gravitystorm commented 11 years ago

Essentially the same as which other issue?

pnorman commented 11 years ago

whoops, #83. the fix is completely different though, for that case it was partially a data issue, but also fixed by the road width changes. Here the data is fine and the road widths are fine.

I found another case at http://www.openstreetmap.org/?lat=49.248&lon=-122.888&zoom=18 (Sydney Ave)

I'm not sure butt would fix it in all cases either, here the road comes in at 45 degrees.

gravitystorm commented 10 years ago

Closing this since there's no straightforward fix.