gravitystorm / openstreetmap-carto

A general-purpose OpenStreetMap mapnik style, in CartoCSS
Other
1.53k stars 817 forks source link

Hotel / Guest_house with Restaurant #969

Closed HolgerJeromin closed 9 years ago

HolgerJeromin commented 9 years ago

A tourism=hotel with amenity=restaurant is rendered exactly as a Restaurant. Not optimal.

matthijsmelissen commented 9 years ago

Related to #963 and #942.

@pnorman, do you think that your fix for #942 would solve the other two issues as well?

pnorman commented 9 years ago

942 is about railways and was specific to that layer.

matthijsmelissen commented 9 years ago

tourism=guest_house is rendered with a blue name but brown Restaurant icon.

I can't reproduce this. Do you have an example?

HolgerJeromin commented 9 years ago

sorry, you are right. Probably i saw two tiles with different age at a funny edge. All consistent brown right now.

matthijsmelissen commented 9 years ago

I can imagine it was a case where one of the names was longer, and only the shorter of the two names fit. But I haven't encounted anything like that in the wild.

HolgerJeromin commented 9 years ago

Please reopen. Only the color mix was false reported. Guest houses and Hotels are not visible if combined with a Restaurant.

matkoniecz commented 9 years ago

Can you give an example?

HolgerJeromin commented 9 years ago

Guest house: on opera mobile i see again the guest house logo and Brown Name. Exactly this poi was Restaurant only on the desktop a few hours ago...

http://www.openstreetmap.org/way/85069658

Hotel: on mobile i see Hotel at the Max zoom, Restaurant before... http://www.openstreetmap.org/way/85069603

Confused...

matkoniecz commented 9 years ago

Exactly this poi was Restaurant only on the desktop a few hours ago...

There are multiple servers rendering tiles, for situation without deterministic rendering results may change in such way. Or maybe feature was recently edited.

lest69 commented 9 years ago

Is it just me, or does this not seem like a tagging error rather than a rendering issue? The way I interpret the current tagging is that the entire building area is BOTH a hotel AND a restaurant occupying the same area. I'm trying to visualize what this would look like. A large open room of diners lying on beds, or separate rooms each with catering and a kitchen? :)

Is this a hotel with a restaurant somewhere inside it? If so, wouldn't this be better tagged as the primary function (hotel), with a restaurant node inside it? Mixing them on the same object creates ambiguity. How can a human, let alone a renderer, decide if this object is primarily a hotel or restaurant? It may be more obvious with a hotel (usually large compared to a restaurant), but a guest_house/restaurant combination is more ambiguous.

HolgerJeromin commented 9 years ago

Level 0 is Restaurant, above is the hotel/guest house. Both full area wide ;-P I dont want to use indoor mapping for this, especially with the same adress, website and other meta data.

lest69 commented 9 years ago

Fair enough.

pnorman commented 9 years ago

Do you have any suggestions for how to render it?

matthijsmelissen commented 9 years ago

I think it's just a generic instance of two POI so close together that we can't render both icons. The same would probably happen if it was a hotel and a restaurant icon close together.

The only thing we can do is decide on priority.

HolgerJeromin commented 9 years ago

mapping the two things as two osm objects would be the same information loss, as one icon is colliding the other. I am thinking about a mixed hotel/restaurant icon. .

Color coding (icon could be mixed, but blue or brown text?) would be an issue.

http://overpass-turbo.eu/s/5c6

dieterdreist commented 9 years ago

2014-09-26 0:13 GMT+02:00 Holger Jeromin notifications@github.com:

Level 0 is Restaurant, above is the hotel/guest house. Both full area wide ;-P I dont want to use indoor mapping for this, especially with the same adress, website and other meta data.

so check-in is in the restaurant? Or in the first floor? There is only one entrance and people are crossing the restaurant to go to their room? Typically these kind of structures still have some internal separation.

matkoniecz commented 9 years ago

Closing per @dieterdreist.

HolgerJeromin commented 9 years ago

This tagging scheme is at least very simple and wide used (2500 nodes, 2100 polygons with hotel+restaurant in Germany). But OK for opening_hours a separation is better, too.