search

gravwell / kits

A collection of open source Gravwell kits
BSD 2-Clause "Simplified" License
3 stars 15 forks source link

PiHole Kit: Adding multiple Pi-Hole instances causes error #160

Open ShaunNeutron opened 8 months ago

ShaunNeutron commented 8 months ago

I run two pihole instances at my house. One is user focused and the other is IOT focused. Based on the installation/setup instructions for the pihole kit, it says that you can separate multiple values by using a comma, which in my mind implies that you can query data from multiple instances. When I define two comma separated IPs and two comma separated API keys, I get the following error:

Scheduled script PiHole Script (374133653) failed at Jan 20 03:50:00: unexpected continue statement

Does the kit support multiple and there is something wrong or does it only support a single instance and the installation tips need to be updated?

mike-wade-gravwell commented 7 months ago

It does not support multiple PiHole instances at the moment. It would probably work if we changed the input for the host and port to a resource but that opens up the possibility for adding to many for the script to handle. I may need to cap it to 3 or 5 instances so the script doesn't get overloaded.