graycoreio / daffodil

Angular Ecommerce PWA Framework
https://next.daff.io
MIT License
154 stars 27 forks source link

[BUG] Tree item links should not have an `aria-expanded` set on it #2855

Closed xelaint closed 1 month ago

xelaint commented 1 month ago

:bug: Bug report

Current Behavior

a[daff-tree-item] has the aria-expanded attribute set on it. It should not have that attribute since links can't be expanded.

Expected Behavior

The aria-expanded should only be set on [daff-tree-item] if it's used with a <button> element.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Creating better accessible components.

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 


For Tooling issues:
- Node version: XX  
- Platform:  

Others: