feat(design)!: remove deprecated properties and directives in `DaffAccordionComponent` and update usage - Githubissues

graycoreio / daffodil

Angular Ecommerce PWA Framework

https://next.daff.io

MIT License

154 stars 27 forks source link

feat(design)!: remove deprecated properties and directives in `DaffAccordionComponent` and update usage #2868

Closed xelaint closed 1 month ago

xelaint commented 1 month ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

daffAccordionItemContent is deprecated.
initiallyActive is deprecated.

Part of: #2853

What is the new behavior?

No longer need to set the directive in order for the content of an accordion item to be placed correctly. Removed all instances of daffAccordionItemContent in usages.
Updated usages of initiallyActive to initiallyExpanded

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information