feat(design)!: add support for `aria-controls` to menu - Githubissues

graycoreio / daffodil

Angular Ecommerce PWA Framework

https://next.daff.io

MIT License

154 stars 27 forks source link

feat(design)!: add support for `aria-controls` to menu #2888

Open xelaint opened 1 month ago

xelaint commented 1 month ago

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2841

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

xelaint commented 1 week ago

Doesn't work if using template ref to implement menu