fix(core): undefined operation entity from `operationFailed` - Githubissues

graycoreio / daffodil

Angular Ecommerce PWA Framework

https://next.daff.io

MIT License

154 stars 27 forks source link

fix(core): undefined operation entity from `operationFailed` #2897

Closed griest024 closed 2 weeks ago

griest024 commented 2 weeks ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Calling operationFailed when the referenced entity does not exist in state causes a bogus entity to be set to the undefined key.

What is the new behavior?

Only entities that are in state will have their error states set.

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information