graycoreio / daffodil

Angular Ecommerce PWA Framework
https://next.daff.io
MIT License
157 stars 31 forks source link

[FEAT] Display Example Viewer in Markdown Files #2903

Open xelaint opened 3 months ago

xelaint commented 3 months ago

:bulb: Feature request

Feature Name

Display Example Viewer in Markdown Files

The Desired Behavior

Your Use Case

As a designer and developer, I expect the example viewer in component markdown files to be visible.

As seen in the screen shots, the <design-land-example-viewer-container> is added to the readme for card. It's not visible on next.daff.io/docs/packages/design/card, but it's shown in the dom when you inspect the page.

Screen Shot 2024-07-08 at 2 16 22 PM Screen Shot 2024-07-08 at 2 16 41 PM Screen Shot 2024-07-08 at 2 18 08 PM

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 


For Tooling issues:
- Node version: XX  
- Platform:  

Others:

griest024 commented 2 months ago

the current method of displaying examples relies on custom elements. Because daffio has SSR, this breaks as Angular does not support custom elements. I'm fairly sure that I can implement a solution that does not rely on CEs but I'm wondering if I should just wait in favor of #2902