graycoreio / daffodil

Angular Ecommerce PWA Framework
https://next.daff.io
MIT License
156 stars 31 forks source link

[FEAT] Allow `aria-labelledby` to be set by the modal service #2915

Closed xelaint closed 2 months ago

xelaint commented 3 months ago

:bulb: Feature request

Feature Name

Allow aria-labelledby to be set by the modal service

The Desired Behavior

If a daffModalTitle is not used, there is no aria-labelledby on the modal to help users know what modal they are on. The aria-labelledby should be an option in the service so that users can set a custom aria-labelledby in this instance. Since we don't actually set <daff-modal> on the usage, setting it in the service is the best way to do this.

Your Use Case

As a developer, I would like to provide a way for users that use assistive technology to know what modal they are currently on if there is no title set.

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 


For Tooling issues:
- Node version: XX  
- Platform:  

Others: