search

graycoreio / magento2-stdlogging

A drop in Magento 2 Module to pump all Magento 2 logs to StdErr instead of files.
MIT License
22 stars 6 forks source link

Update composer.json to use compatible monolog version #4

Closed marciomaciel closed 3 years ago

marciomaciel commented 3 years ago

Changed monolog version from "1.17" to "^1.16" to match version used in Magento 2.4

damienwebdev commented 3 years ago

/azp run

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 1 pipeline(s).
benjick commented 3 years ago

Will this be merged?

Getting this error while installing:

Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - Can only install one of: monolog/monolog[1.25.5, 1.17.0].
    - Can only install one of: monolog/monolog[1.17.0, 1.25.5].
    - Can only install one of: monolog/monolog[1.17.0, 1.25.5].
    - graycore/magento2-stdlogging v1.1.0 requires monolog/monolog 1.17 -> satisfiable by monolog/monolog[1.17.0].
    - Installation request for graycore/magento2-stdlogging ^1.1 -> satisfiable by graycore/magento2-stdlogging[v1.1.0].
    - Installation request for monolog/monolog (locked at 1.25.5) -> satisfiable by monolog/monolog[1.25.5].

and I guess this PR will fix that

damienwebdev commented 3 years ago

The code is fine, I just don't have the time to bump the lockfile (seems ridiculous I know). @benjick if you wouldn't mind submitting a PR to bump the deps and the lockfile, I'd merge it.

damienwebdev commented 3 years ago

Closing in favor of https://github.com/graycoreio/magento2-stdlogging/commit/3380ca7a3c971b7f857b77821a582459f9055c34

damienwebdev commented 3 years ago

@benjick this is merged and released as v1.1.1.