graydon / bors

Integration robot for buildbot and github
424 stars 49 forks source link

bors retried the same pull request over and over and over #11

Closed bhearsum closed 11 years ago

bhearsum commented 11 years ago

We hit this today on the Servo Bors. Issue #617 was pushed by Bors, then Bors ran again and said it was running tests, and then every subsequent run pushed it again and again. The logs from the first three runs are below: 4055 2013-07-24 13:33:01 PDT - INFO - ---------- starting run ---------- 4056 2013-07-24 13:33:01 PDT - INFO - loading bors.cfg 4057 2013-07-24 13:33:01 PDT - INFO - loading pull reqs (page 1) 4058 2013-07-24 13:33:02 PDT - INFO - loading pull reqs (page 2) 4059 2013-07-24 13:33:03 PDT - INFO - loading pull and issue comments on pull #617 4060 2013-07-24 13:33:04 PDT - INFO - loading head comments on kmcallister/servo/test-html = 350c0a61 4061 2013-07-24 13:33:06 PDT - INFO - loading statuses of kmcallister/servo/test-html = 350c0a61 4062 2013-07-24 13:33:06 PDT - INFO - loading mergeability of 617 4063 2013-07-24 13:33:07 PDT - INFO - loading pull and issue comments on pull #553 4064 2013-07-24 13:33:08 PDT - INFO - loading head comments on pcwalton/servo/cpu-rendering = 707846f5 4065 2013-07-24 13:33:10 PDT - INFO - loading statuses of pcwalton/servo/cpu-rendering = 707846f5 4066 2013-07-24 13:33:10 PDT - INFO - loading mergeability of 553 4067 2013-07-24 13:33:11 PDT - INFO - loading pull and issue comments on pull #439 4068 2013-07-24 13:33:13 PDT - INFO - loading head comments on yichoi/servo/current = a196dc17 4069 2013-07-24 13:33:14 PDT - INFO - loading statuses of yichoi/servo/current = a196dc17 4070 2013-07-24 13:33:14 PDT - INFO - loading mergeability of 439 4071 2013-07-24 13:33:18 PDT - INFO - got 3 open pull reqs 4072 2013-07-24 13:33:18 PDT - INFO - got 1 viable pull reqs 4073 2013-07-24 13:33:18 PDT - INFO - (2,0) : pull https://github.com/mozilla/servo/pull/617 - kmcallister/servo/test-html = 350c0a61 - 'Add an HTML file where JavaScr' 4074 2013-07-24 13:33:18 PDT - INFO - working with most-ripe pull kmcallister/servo/test-html = 350c0a61 4075 2013-07-24 13:33:18 PDT - INFO - considering pull https://github.com/mozilla/servo/pull/617 - kmcallister/servo/test-html = 350c0a61 - 'Add an HTML file where JavaSc r' 4076 2013-07-24 13:33:18 PDT - INFO - kmcallister/servo/test-html = 350c0a61 - found approval, advancing to test 4077 2013-07-24 13:33:19 PDT - INFO - resetting auto to master = fe91f6e2 4078 2013-07-24 13:33:20 PDT - INFO - merging kmcallister/servo/test-html = 350c0a61 into auto 4079 2013-07-24 13:33:22 PDT - INFO - kmcallister/servo/test-html = 350c0a61 merged ok, testing candidate = a1c02ded 4080 2013-07-24 13:33:23 PDT - INFO - kmcallister/servo/test-html = 350c0a61 - setting status: pending ({'target_url': 'https://github.com/mozilla/servo/commit/a1c02ded3c a015af430d42f294326c5ec12c2c32', 'description': 'running tests'})

4081 2013-07-24 13:36:01 PDT - INFO - ---------- starting run ---------- 4082 2013-07-24 13:36:01 PDT - INFO - loading bors.cfg 4083 2013-07-24 13:36:01 PDT - INFO - loading pull reqs (page 1) 4084 2013-07-24 13:36:02 PDT - INFO - loading pull reqs (page 2) 4085 2013-07-24 13:36:03 PDT - INFO - loading pull and issue comments on pull #617 4086 2013-07-24 13:36:04 PDT - INFO - loading head comments on kmcallister/servo/test-html = 350c0a61 4087 2013-07-24 13:36:05 PDT - INFO - loading statuses of kmcallister/servo/test-html = 350c0a61 4088 2013-07-24 13:36:05 PDT - INFO - loading mergeability of 617 4089 2013-07-24 13:36:06 PDT - INFO - loading pull and issue comments on pull #553 4090 2013-07-24 13:36:08 PDT - INFO - loading head comments on pcwalton/servo/cpu-rendering = 707846f5 4091 2013-07-24 13:36:09 PDT - INFO - loading statuses of pcwalton/servo/cpu-rendering = 707846f5 4092 2013-07-24 13:36:09 PDT - INFO - loading mergeability of 553 4093 2013-07-24 13:36:10 PDT - INFO - loading pull and issue comments on pull #439 4094 2013-07-24 13:36:11 PDT - INFO - loading head comments on yichoi/servo/current = a196dc17 4095 2013-07-24 13:36:13 PDT - INFO - loading statuses of yichoi/servo/current = a196dc17 4096 2013-07-24 13:36:13 PDT - INFO - loading mergeability of 439 4097 2013-07-24 13:36:15 PDT - INFO - test ref 'auto' = a1c02ded, parents: 'master' = fe91f6e2 and candidate = 350c0a61 4098 2013-07-24 13:36:15 PDT - INFO - candidate = 350c0a61 found in pull req kmcallister/servo/test-html = 350c0a61 4099 2013-07-24 13:36:15 PDT - INFO - got 3 open pull reqs 4100 2013-07-24 13:36:15 PDT - INFO - got 1 viable pull reqs 4101 2013-07-24 13:36:15 PDT - INFO - (3,0) : pull https://github.com/mozilla/servo/pull/617 - kmcallister/servo/test-html = 350c0a61 - 'Add an HTML file where JavaScr' 4102 2013-07-24 13:36:15 PDT - INFO - working with most-ripe pull kmcallister/servo/test-html = 350c0a61 4103 2013-07-24 13:36:15 PDT - INFO - considering pull https://github.com/mozilla/servo/pull/617 - kmcallister/servo/test-html = 350c0a61 - 'Add an HTML file where JavaSc r' 4104 2013-07-24 13:36:15 PDT - INFO - kmcallister/servo/test-html = 350c0a61 - found pending state, checking tests 4105 2013-07-24 13:36:15 PDT - INFO - loading build/test status from buildbot 4106 2013-07-24 13:36:15 PDT - INFO - fetching http://servo-buildbot.pub.build.mozilla.org/json/builders/linux/builds?select=-1&select=-2&select=-3&select=-4&select=-5 4107 2013-07-24 13:36:16 PDT - INFO - fetching http://servo-buildbot.pub.build.mozilla.org/json/builders/mac/builds?select=-1&select=-2&select=-3&select=-4&select=-5 4108 2013-07-24 13:36:16 PDT - INFO - missing info sha a1c02ded3ca015af430d42f294326c5ec12c2c32 4109 2013-07-24 13:36:16 PDT - INFO - kmcallister/servo/test-html = 350c0a61 - no info yet, waiting on tests

4110 2013-07-24 13:39:02 PDT - INFO - ---------- starting run ---------- 4111 2013-07-24 13:39:02 PDT - INFO - loading bors.cfg 4112 2013-07-24 13:39:02 PDT - INFO - loading pull reqs (page 1) 4113 2013-07-24 13:39:03 PDT - INFO - loading pull reqs (page 2) 4114 2013-07-24 13:39:03 PDT - INFO - loading pull and issue comments on pull #617 4115 2013-07-24 13:39:05 PDT - INFO - loading head comments on kmcallister/servo/test-html = 350c0a61 4116 2013-07-24 13:39:06 PDT - INFO - loading statuses of kmcallister/servo/test-html = 350c0a61 4117 2013-07-24 13:39:06 PDT - INFO - loading mergeability of 617 4118 2013-07-24 13:39:07 PDT - INFO - loading pull and issue comments on pull #553 4119 2013-07-24 13:39:08 PDT - INFO - loading head comments on pcwalton/servo/cpu-rendering = 707846f5 4120 2013-07-24 13:39:10 PDT - INFO - loading statuses of pcwalton/servo/cpu-rendering = 707846f5 4121 2013-07-24 13:39:10 PDT - INFO - loading mergeability of 553 4122 2013-07-24 13:39:10 PDT - INFO - loading pull and issue comments on pull #439 4123 2013-07-24 13:39:12 PDT - INFO - loading head comments on yichoi/servo/current = a196dc17 4124 2013-07-24 13:39:13 PDT - INFO - loading statuses of yichoi/servo/current = a196dc17 4125 2013-07-24 13:39:13 PDT - INFO - loading mergeability of 439 4126 2013-07-24 13:39:16 PDT - INFO - test ref 'auto' = a1c02ded, parents: 'master' = fe91f6e2 and candidate = 350c0a61 4127 2013-07-24 13:39:16 PDT - INFO - candidate = 350c0a61 found in pull req kmcallister/servo/test-html = 350c0a61 4128 2013-07-24 13:39:16 PDT - INFO - got 3 open pull reqs 4129 2013-07-24 13:39:16 PDT - INFO - got 1 viable pull reqs 4130 2013-07-24 13:39:16 PDT - INFO - (2,0) : pull https://github.com/mozilla/servo/pull/617 - kmcallister/servo/test-html = 350c0a61 - 'Add an HTML file where JavaScr' 4131 2013-07-24 13:39:16 PDT - INFO - working with most-ripe pull kmcallister/servo/test-html = 350c0a61 4132 2013-07-24 13:39:16 PDT - INFO - considering pull https://github.com/mozilla/servo/pull/617 - kmcallister/servo/test-html = 350c0a61 - 'Add an HTML file where JavaSc r' 4133 2013-07-24 13:39:16 PDT - INFO - kmcallister/servo/test-html = 350c0a61 - found approval, advancing to test 4134 2013-07-24 13:39:18 PDT - INFO - resetting auto to master = fe91f6e2 4135 2013-07-24 13:39:18 PDT - INFO - merging kmcallister/servo/test-html = 350c0a61 into auto 4136 2013-07-24 13:39:20 PDT - INFO - kmcallister/servo/test-html = 350c0a61 merged ok, testing candidate = 513c09c3 4137 2013-07-24 13:39:21 PDT - INFO - kmcallister/servo/test-html = 350c0a61 - setting status: pending ({'target_url': 'https://github.com/mozilla/servo/commit/513c09c372 e1cad69339976ea46ea8082b6ed11c', 'description': 'running tests'})

The builds from the original push didn't hit any issues (http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/linux/builds/157 and http://buildbot-master-servo-01.srv.servo.releng.use1.mozilla.com:8001/builders/mac/builds/128).

The only code that sets PENDING is this block: https://github.com/graydon/bors/blob/master/bors.py#L401, so I presume that the pendings vs. retries comparison is ending up in APPROVAL. I don't know why, though.

bhearsum commented 11 years ago

Added some debug output and found that both pendings and retries are 0. This makes me think that the merge status of https://github.com/mozilla/servo/pull/617 is somehow broken. Even though the web interface claims it's "running tests", it's still returning 0 AFAICT.

bhearsum commented 11 years ago

Current state of that PR is: { "url": "https://api.github.com/repos/mozilla/servo/pulls/617", "id": 7148894, "html_url": "https://github.com/mozilla/servo/pull/617", "diff_url": "https://github.com/mozilla/servo/pull/617.diff", "patch_url": "https://github.com/mozilla/servo/pull/617.patch", "issue_url": "https://github.com/mozilla/servo/issues/617", "number": 617, "state": "open", "title": "Add an HTML file where JavaScript changes text color", "user": { "login": "kmcallister", "id": 444997, "avatar_url": "https://secure.gravatar.com/avatar/ac0ed9efe05910cd536b5022b005c80a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png", "gravatar_id": "ac0ed9efe05910cd536b5022b005c80a", "url": "https://api.github.com/users/kmcallister", "html_url": "https://github.com/kmcallister", "followers_url": "https://api.github.com/users/kmcallister/followers", "following_url": "https://api.github.com/users/kmcallister/following{/other_user}", "gists_url": "https://api.github.com/users/kmcallister/gists{/gist_id}", "starred_url": "https://api.github.com/users/kmcallister/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kmcallister/subscriptions", "organizations_url": "https://api.github.com/users/kmcallister/orgs", "repos_url": "https://api.github.com/users/kmcallister/repos", "events_url": "https://api.github.com/users/kmcallister/events{/privacy}", "received_events_url": "https://api.github.com/users/kmcallister/received_events", "type": "User" }, "body": "I wanted this for testing incremental layout, but it's also useful to illustrate a bug I just found.", "created_at": "2013-07-24T20:10:28Z", "updated_at": "2013-07-24T21:20:40Z", "closed_at": null, "merged_at": null, "merge_commit_sha": "8073f338ada6b8271c2f0a0fed050ddaa41ee535", "assignee": null, "milestone": null, "commits_url": "https://github.com/mozilla/servo/pull/617/commits", "review_comments_url": "https://github.com/mozilla/servo/pull/617/comments", "review_comment_url": "/repos/mozilla/servo/pulls/comments/{number}", "comments_url": "https://api.github.com/repos/mozilla/servo/issues/617/comments", "head": { "label": "kmcallister:test-html", "ref": "test-html", "sha": "350c0a61c6c705b2f4c1b095064ee337f17a1c9e", "user": { "login": "kmcallister", "id": 444997, "avatar_url": "https://secure.gravatar.com/avatar/ac0ed9efe05910cd536b5022b005c80a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png", "gravatar_id": "ac0ed9efe05910cd536b5022b005c80a", "url": "https://api.github.com/users/kmcallister", "html_url": "https://github.com/kmcallister", "followers_url": "https://api.github.com/users/kmcallister/followers", "following_url": "https://api.github.com/users/kmcallister/following{/other_user}", "gists_url": "https://api.github.com/users/kmcallister/gists{/gist_id}", "starred_url": "https://api.github.com/users/kmcallister/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kmcallister/subscriptions", "organizations_url": "https://api.github.com/users/kmcallister/orgs", "repos_url": "https://api.github.com/users/kmcallister/repos", "events_url": "https://api.github.com/users/kmcallister/events{/privacy}", "received_events_url": "https://api.github.com/users/kmcallister/received_events", "type": "User" }, "repo": { "id": 11292718, "name": "servo", "full_name": "kmcallister/servo", "owner": { "login": "kmcallister", "id": 444997, "avatar_url": "https://secure.gravatar.com/avatar/ac0ed9efe05910cd536b5022b005c80a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png", "gravatar_id": "ac0ed9efe05910cd536b5022b005c80a", "url": "https://api.github.com/users/kmcallister", "html_url": "https://github.com/kmcallister", "followers_url": "https://api.github.com/users/kmcallister/followers", "following_url": "https://api.github.com/users/kmcallister/following{/other_user}", "gists_url": "https://api.github.com/users/kmcallister/gists{/gist_id}", "starred_url": "https://api.github.com/users/kmcallister/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kmcallister/subscriptions", "organizations_url": "https://api.github.com/users/kmcallister/orgs", "repos_url": "https://api.github.com/users/kmcallister/repos", "events_url": "https://api.github.com/users/kmcallister/events{/privacy}", "received_events_url": "https://api.github.com/users/kmcallister/received_events", "type": "User" }, "private": false, "html_url": "https://github.com/kmcallister/servo", "description": "The Servo Browser Engine", "fork": true, "url": "https://api.github.com/repos/kmcallister/servo", "forks_url": "https://api.github.com/repos/kmcallister/servo/forks", "keys_url": "https://api.github.com/repos/kmcallister/servo/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/kmcallister/servo/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/kmcallister/servo/teams", "hooks_url": "https://api.github.com/repos/kmcallister/servo/hooks", "issue_events_url": "https://api.github.com/repos/kmcallister/servo/issues/events{/number}", "events_url": "https://api.github.com/repos/kmcallister/servo/events", "assignees_url": "https://api.github.com/repos/kmcallister/servo/assignees{/user}", "branches_url": "https://api.github.com/repos/kmcallister/servo/branches{/branch}", "tags_url": "https://api.github.com/repos/kmcallister/servo/tags", "blobs_url": "https://api.github.com/repos/kmcallister/servo/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/kmcallister/servo/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/kmcallister/servo/git/refs{/sha}", "trees_url": "https://api.github.com/repos/kmcallister/servo/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/kmcallister/servo/statuses/{sha}", "languages_url": "https://api.github.com/repos/kmcallister/servo/languages", "stargazers_url": "https://api.github.com/repos/kmcallister/servo/stargazers", "contributors_url": "https://api.github.com/repos/kmcallister/servo/contributors", "subscribers_url": "https://api.github.com/repos/kmcallister/servo/subscribers", "subscription_url": "https://api.github.com/repos/kmcallister/servo/subscription", "commits_url": "https://api.github.com/repos/kmcallister/servo/commits{/sha}", "git_commits_url": "https://api.github.com/repos/kmcallister/servo/git/commits{/sha}", "comments_url": "https://api.github.com/repos/kmcallister/servo/comments{/number}", "issue_comment_url": "https://api.github.com/repos/kmcallister/servo/issues/comments/{number}", "contents_url": "https://api.github.com/repos/kmcallister/servo/contents/{+path}", "compare_url": "https://api.github.com/repos/kmcallister/servo/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/kmcallister/servo/merges", "archive_url": "https://api.github.com/repos/kmcallister/servo/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/kmcallister/servo/downloads", "issues_url": "https://api.github.com/repos/kmcallister/servo/issues{/number}", "pulls_url": "https://api.github.com/repos/kmcallister/servo/pulls{/number}", "milestones_url": "https://api.github.com/repos/kmcallister/servo/milestones{/number}", "notifications_url": "https://api.github.com/repos/kmcallister/servo/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/kmcallister/servo/labels{/name}", "created_at": "2013-07-09T20:05:17Z", "updated_at": "2013-07-24T21:20:40Z", "pushed_at": "2013-07-24T20:10:11Z", "git_url": "git://github.com/kmcallister/servo.git", "ssh_url": "git@github.com:kmcallister/servo.git", "clone_url": "https://github.com/kmcallister/servo.git", "svn_url": "https://github.com/kmcallister/servo", "homepage": "", "size": 5989, "watchers_count": 0, "language": "Python", "has_issues": false, "has_downloads": true, "has_wiki": true, "forks_count": 0, "mirror_url": null, "open_issues_count": 0, "forks": 0, "open_issues": 0, "watchers": 0, "master_branch": "master", "default_branch": "master" } }, "base": { "label": "mozilla:master", "ref": "master", "sha": "fe91f6e238acd9e423d98c18c906416be3090eb3", "user": { "login": "mozilla", "id": 131524, "avatar_url": "https://secure.gravatar.com/avatar/9ba739c8f3288e256b13553e4d257b5e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-org-420.png", "gravatar_id": "9ba739c8f3288e256b13553e4d257b5e", "url": "https://api.github.com/users/mozilla", "html_url": "https://github.com/mozilla", "followers_url": "https://api.github.com/users/mozilla/followers", "following_url": "https://api.github.com/users/mozilla/following{/other_user}", "gists_url": "https://api.github.com/users/mozilla/gists{/gist_id}", "starred_url": "https://api.github.com/users/mozilla/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mozilla/subscriptions", "organizations_url": "https://api.github.com/users/mozilla/orgs", "repos_url": "https://api.github.com/users/mozilla/repos", "events_url": "https://api.github.com/users/mozilla/events{/privacy}", "received_events_url": "https://api.github.com/users/mozilla/received_events", "type": "Organization" }, "repo": { "id": 3390243, "name": "servo", "full_name": "mozilla/servo", "owner": { "login": "mozilla", "id": 131524, "avatar_url": "https://secure.gravatar.com/avatar/9ba739c8f3288e256b13553e4d257b5e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-org-420.png", "gravatar_id": "9ba739c8f3288e256b13553e4d257b5e", "url": "https://api.github.com/users/mozilla", "html_url": "https://github.com/mozilla", "followers_url": "https://api.github.com/users/mozilla/followers", "following_url": "https://api.github.com/users/mozilla/following{/other_user}", "gists_url": "https://api.github.com/users/mozilla/gists{/gist_id}", "starred_url": "https://api.github.com/users/mozilla/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mozilla/subscriptions", "organizations_url": "https://api.github.com/users/mozilla/orgs", "repos_url": "https://api.github.com/users/mozilla/repos", "events_url": "https://api.github.com/users/mozilla/events{/privacy}", "received_events_url": "https://api.github.com/users/mozilla/received_events", "type": "Organization" }, "private": false, "html_url": "https://github.com/mozilla/servo", "description": "The Servo Browser Engine", "fork": false, "url": "https://api.github.com/repos/mozilla/servo", "forks_url": "https://api.github.com/repos/mozilla/servo/forks", "keys_url": "https://api.github.com/repos/mozilla/servo/keys{/key_id}", "collaborators_url": "https://api.github.com/repos/mozilla/servo/collaborators{/collaborator}", "teams_url": "https://api.github.com/repos/mozilla/servo/teams", "hooks_url": "https://api.github.com/repos/mozilla/servo/hooks", "issue_events_url": "https://api.github.com/repos/mozilla/servo/issues/events{/number}", "events_url": "https://api.github.com/repos/mozilla/servo/events", "assignees_url": "https://api.github.com/repos/mozilla/servo/assignees{/user}", "branches_url": "https://api.github.com/repos/mozilla/servo/branches{/branch}", "tags_url": "https://api.github.com/repos/mozilla/servo/tags", "blobs_url": "https://api.github.com/repos/mozilla/servo/git/blobs{/sha}", "git_tags_url": "https://api.github.com/repos/mozilla/servo/git/tags{/sha}", "git_refs_url": "https://api.github.com/repos/mozilla/servo/git/refs{/sha}", "trees_url": "https://api.github.com/repos/mozilla/servo/git/trees{/sha}", "statuses_url": "https://api.github.com/repos/mozilla/servo/statuses/{sha}", "languages_url": "https://api.github.com/repos/mozilla/servo/languages", "stargazers_url": "https://api.github.com/repos/mozilla/servo/stargazers", "contributors_url": "https://api.github.com/repos/mozilla/servo/contributors", "subscribers_url": "https://api.github.com/repos/mozilla/servo/subscribers", "subscription_url": "https://api.github.com/repos/mozilla/servo/subscription", "commits_url": "https://api.github.com/repos/mozilla/servo/commits{/sha}", "git_commits_url": "https://api.github.com/repos/mozilla/servo/git/commits{/sha}", "comments_url": "https://api.github.com/repos/mozilla/servo/comments{/number}", "issue_comment_url": "https://api.github.com/repos/mozilla/servo/issues/comments/{number}", "contents_url": "https://api.github.com/repos/mozilla/servo/contents/{+path}", "compare_url": "https://api.github.com/repos/mozilla/servo/compare/{base}...{head}", "merges_url": "https://api.github.com/repos/mozilla/servo/merges", "archive_url": "https://api.github.com/repos/mozilla/servo/{archive_format}{/ref}", "downloads_url": "https://api.github.com/repos/mozilla/servo/downloads", "issues_url": "https://api.github.com/repos/mozilla/servo/issues{/number}", "pulls_url": "https://api.github.com/repos/mozilla/servo/pulls{/number}", "milestones_url": "https://api.github.com/repos/mozilla/servo/milestones{/number}", "notifications_url": "https://api.github.com/repos/mozilla/servo/notifications{?since,all,participating}", "labels_url": "https://api.github.com/repos/mozilla/servo/labels{/name}", "created_at": "2012-02-08T19:07:25Z", "updated_at": "2013-07-24T21:27:22Z", "pushed_at": "2013-07-24T21:27:19Z", "git_url": "git://github.com/mozilla/servo.git", "ssh_url": "git@github.com:mozilla/servo.git", "clone_url": "https://github.com/mozilla/servo.git", "svn_url": "https://github.com/mozilla/servo", "homepage": "", "size": 8954, "watchers_count": 1004, "language": "Python", "has_issues": true, "has_downloads": true, "has_wiki": true, "forks_count": 126, "mirror_url": null, "open_issues_count": 199, "forks": 126, "open_issues": 199, "watchers": 1004, "master_branch": "master", "default_branch": "master" } }, "_links": { "self": { "href": "https://api.github.com/repos/mozilla/servo/pulls/617" }, "html": { "href": "https://github.com/mozilla/servo/pull/617" }, "issue": { "href": "https://api.github.com/repos/mozilla/servo/issues/617" }, "comments": { "href": "https://api.github.com/repos/mozilla/servo/issues/617/comments" }, "review_comments": { "href": "https://api.github.com/repos/mozilla/servo/pulls/617/comments" } }, "merged": false, "mergeable": true, "mergeable_state": "unstable", "merged_by": null, "comments": 0, "review_comments": 0, "commits": 1, "additions": 17, "deletions": 0, "changed_files": 2 }

bhearsum commented 11 years ago

And https://api.github.com/repos/mozilla/servo/statuses/fe91f6e238acd9e423d98c18c906416be3090eb3 returns: [

]

Which seems a little broken.

bhearsum commented 11 years ago

jdm just noticed that we have two commits with the same hash and different contents: https://github.com/mozilla/servo/commit/350c0a61c6c705b2f4c1b095064ee337f17a1c9e https://github.com/kmcallister/servo/commit/350c0a61c6c705b2f4c1b095064ee337f17a1c9e

bhearsum commented 11 years ago

Pretty sure this was a github issue, not a hash collision.