Rollup fixes - Githubissues

graydon / bors

Integration robot for buildbot and github

427 stars 49 forks source link

Rollup fixes #48

Closed barosl closed 9 years ago

barosl commented 9 years ago

Changes summary:

Bug fix: Include only the pull requests marked as "rollup" when creating a rollup
Use commit comments to save additional information, such as the commit IDs of the PRs
If one of the PRs advances or force-pushes, test again without the PR (a.k.a. "freshness" check)

Gankra commented 9 years ago

r? @brson

barosl commented 9 years ago

As bors now caches commit IDs in the comments, some GitHub API calls could be eliminated. However, you should @bors: retry to the existing PENDING pull request after deploying this (there is only one PENDING pull request at a time), because the cache is generated when a PR's status is changed from APPROVED to PENDING.

barosl commented 9 years ago

More changes here:

Try to do more transitions in the same run. Fixes #35.
Occasionally the pull request is set to closed when it should be merged. Try to resolve this.

brson commented 9 years ago

I'm just going to merge this and hope it works.