search

graykode / nlp-tutorial

Natural Language Processing Tutorial for Deep Learning Researchers
https://www.reddit.com/r/MachineLearning/comments/amfinl/project_nlptutoral_repository_who_is_studying/
MIT License
14.07k stars 3.91k forks source link

Fixed UserWarning #11

Closed us closed 5 years ago

us commented 5 years ago 

  warnings.warn("nn.functional.tanh is deprecated. Use torch.tanh instead.")```
graykode commented 5 years ago

Hello Thanks for Contribution. tanh = torch..tanh(*) will be invalid syntax error. Could you pull request again to be right? Also if you pr about *py, i will apply your python code in jupyter notebook code Have a good day

us commented 5 years ago

No my pr about .py and .ipynb file of torch. And syntax error corrected. Thanks.

graykode commented 5 years ago

Thanks. But Could You Pr again only .py file ? because there will be made 3 commits not need,,. Sorry :( TT I will apply your python code to Jupyter file, beacuase there may be some different environment on your Jupyter Setting. > commit

I hope commit like this ! : here So Could you give Pr about python code with edited

Please reset your commit here

$ git reset 06ca9dda51b82f870a06ab20afc7593893c92177
# edit NNLM-Torch.py `nn.functional` to `torch`
# give me Pull Request again :D

I will close this Pr and also wait your new pull request, Thanks @us