search

graykode / nlp-tutorial

Natural Language Processing Tutorial for Deep Learning Researchers
https://www.reddit.com/r/MachineLearning/comments/amfinl/project_nlptutoral_repository_who_is_studying/
MIT License
14.07k stars 3.91k forks source link

Seq2Seq pytorch #19

Closed DonghyungKo closed 5 years ago

DonghyungKo commented 5 years ago

Hi thanks for sharing your codes.

I've had read your seq2seq implementation and I was wondering about the RNN Encode-Decode model.

in the paper, 'Learning Phrase Representations using RNN Encoder–Decoder for Statistical Machine Translation'

They say

image

proposed gating unit image

and I couldn't find the new hidden-state activation function in your code.

Do you have any plan to add the proposed activation process? or is it okay to just skip the parts?

thank you so much in advance

graykode commented 5 years ago

Yes. but, Contribution is always open

DonghyungKo commented 5 years ago

thank you

I was just wondering whether it matters or not

straight-forward code btw, really nice work thanks