remove autograd.Variable and fixed symbol P

graykode / nlp-tutorial

Natural Language Processing Tutorial for Deep Learning Researchers

https://www.reddit.com/r/MachineLearning/comments/amfinl/project_nlptutoral_repository_who_is_studying/

MIT License

14.07k stars 3.91k forks source link

remove autograd.Variable and fixed symbol P #20

Closed SpellOnYou closed 5 years ago

SpellOnYou commented 5 years ago

The variable API has been deprecated. you can remove this. I just provided an example with basic attention model. if you agree with me, retune it. https://pytorch.org/docs/stable/autograd.html#variable-deprecated
sequence to sequence model has n_step variable(i guess you mean padding... right? but I just little confused that you used identical terminology even if this is tutorial.

graykode commented 5 years ago

@SpellOnYou Thanks for Contribution, but Why don't you recommit your github nickname to stay? Could you recommit with git config user.name='github id'? If you dont want, Please write on this thread. Thanks!

graykode commented 5 years ago

@SpellOnYou There is some wrong thing. 'P' is abbreviation of [PAD]