search

graykode / nlp-tutorial

Natural Language Processing Tutorial for Deep Learning Researchers
https://www.reddit.com/r/MachineLearning/comments/amfinl/project_nlptutoral_repository_who_is_studying/
MIT License
14.03k stars 3.9k forks source link

FIX transformer init #37

Closed wking-tao closed 4 years ago

wking-tao commented 4 years ago

A nice solution for both issue #29 and #35

graykode commented 4 years ago

@wking-tao I admit that your code representation is a bit more pytorch. so I'll merge it

I will re-establish the guide for contributions so that the ipynb code will automatically be dev ops. From next time, please contribute only python code.

I plan to upgrade the code a little further according to the corresponding below PR:

57