search

graykode / nlp-tutorial

Natural Language Processing Tutorial for Deep Learning Researchers
https://www.reddit.com/r/MachineLearning/comments/amfinl/project_nlptutoral_repository_who_is_studying/
MIT License
14.03k stars 3.9k forks source link

Update NNLM-Torch.py #51

Closed wmathor closed 4 years ago

wmathor commented 4 years ago
  1. delete Variable, because in new version PyTorch is not used
  2. modify the annotation
graykode commented 4 years ago

@wmathor Thanks for your large contribution. however, It doesn't seem a good idea to have a personal video of the readme and modify all of the framework's requirements with just one file modification(not all files). It seems like a better way to open an issue and attach it to a related video or the forked downstream repository.

I plan to upgrade the code a little further according to the corresponding below PR:

57

Also, I will re-establish the guide for contributions so that the ipynb code will automatically be dev ops. From next time, please contribute only python code.

best regard. Tae Hwan