graykode / nlp-tutorial

Natural Language Processing Tutorial for Deep Learning Researchers

MIT License

14.03k stars 3.9k forks source link

Closed secsilm closed 3 years ago

secsilm commented 3 years ago

Small mistakes in NNLM:

X = self.C(X) # X : [batch_size, n_step, n_class]
X = X.view(-1, n_step * m) # [batch_size, n_step * n_class]

should be

X = self.C(X) # X : [batch_size, n_step, m]
X = X.view(-1, n_step * m) # [batch_size, n_step * m]

48

ZonePG commented 3 years ago

@secsilm you are right, I think so too