Add TLS support for TCP protocol

graylog-labs / gelf-rb

Ruby GELF library (Graylog Extended Log Format)

https://rubygems.org/gems/gelf

MIT License

153 stars 104 forks source link

Add TLS support for TCP protocol #39

Closed edefaria closed 8 years ago

edefaria commented 8 years ago

Add TLS Support:

Add a new array config option for TLS option management
Possible to force TLS version for higher security
Possible to verify the certificate is trusted

Bugfix:

detect half-open socket by reading the socket after writing and socket error return by the server
fix possible issue when "default_options" is nil

TCP improvement:

Add close definition for manually closing TCP connection
Add the possibility to set a number of retry when sending message (default unlimited)

bernd commented 8 years ago

Thank you for the PR!

See comments.

bernd commented 8 years ago

Nevermind, I will just merge this and apply some fixes. :smiley:

Watch out for some changes. :wink:

Thanks again for your contribution! :+1:

lennartkoopmann commented 8 years ago

:+1: Thanks @bernd and @edefaria!

bernd commented 8 years ago

@edefaria Sorry, I had to revert this because we need a signed Contributor License Agreement before we can merge this. I thought we already got this from you, but I was wrong.

Please follow the instructions here: https://www.graylog.org/get-involved (down at the bottom of the page)

We will happily merge your contribution once we receive the signed CLA. Thank you very much!

bernd commented 8 years ago

@edefaria We received the CLA, thank you! :smiley:

I will merge this soon!

milgner commented 8 years ago

Are there any blockers on this? If this is working as it should, I'd use this branch as a base to also add certificate authentication.

milgner commented 8 years ago

After reading the commit message on the revert commit and looking at the changes that the master branch has gone through, I started a new approach at supporting TLS at https://github.com/milgner/gelf-rb/tree/feature/tcp-tls-cert-auth Right now it's pre-PR-quality since I just quickly cobbled it together and still lacking tests, but it supports client certificate authentication in addition to encryption. Feedback is appreciated, let me know what you think. I don't know how much time I'll have to polish it but I think I'll deploy it in a test environment and see what happens :wink: