Open ferrous26 opened 8 years ago
Hi @ferrous26,
support for IPv6 is very welcome! Nonetheless I'm a bit uncomfortable with the rest of the changes as this drops support for quite a number of old Ruby versions and seems to pull in a dependency on ActiveSupport. Also, we should provide a possibility to make the connect
call on the socket optional to prevent breaking it for setups that use special DNS setups like round-robin.
If you could rebase it onto the current master
branch (which already addresses a number of changes you made here, too), it would be much appreciated.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
And set the socket host and port at init time so that it does not have to make a DNS call for every send.
Also update dependencies and clear warnings so that things work smoothly on Ruby 2.3.0.