Ignore empty messages logging

graylog-labs / gelf-rb

Ruby GELF library (Graylog Extended Log Format)

https://rubygems.org/gems/gelf

MIT License

153 stars 104 forks source link

Ignore empty messages logging #50

Closed mehlah closed 6 years ago

mehlah commented 8 years ago

This is basically a replacement for #12 which is stale for a couple years. Empty messages (looking at you Rails!) are now ignored, to avoid raised errors by Notifier#check_presence_of_mandatory_attributes

PS: I signed and sent the CA.

dennisoelkers commented 8 years ago

Hey @mehlah, thanks for submitting the PR. Unfortunately we have not received your signed CLA. But in the meantime we have switched our process to CLA assistant, so all you need to do is click on "Details" next to the licence/cla check and accept our CLA.

mehlah commented 8 years ago

@dennisoelkers done 📝

paulRbr commented 7 years ago

This PR looks good. Any chance it could be merged in?