search

graylog-labs / gelf-rb

Ruby GELF library (Graylog Extended Log Format)
https://rubygems.org/gems/gelf
MIT License
153 stars 104 forks source link

remove deprecated field "facility" #56

Closed n3xus closed 7 years ago

n3xus commented 7 years ago

facility is deprecated in Gelf specification.

Thus removed facility.

joschi commented 7 years ago

@n3xus I'm a bit reluctant to remove the facility from the GELF messages created by this library.

While the facility field has been deprecated, it's still being processed by Graylog (as of version 2.3.0): https://github.com/Graylog2/graylog2-server/blob/2.3.0/graylog2-server/src/main/java/org/graylog2/inputs/codecs/GelfCodec.java#L171-L175

Removing it would suddenly change the messages created by this library and irritate people who use the facility field for filtering or in any other queries.

joschi commented 7 years ago

@n3xus As a soft migration path, it would probably make sense to use the custom _facility field instead of facility so that users can override the facility if they want to.