Open tessie opened 6 years ago
@tessie first things first: thank you for helping out! I'm really sorry I've been so unresponsive for so long, will try becoming more involved if necessary.
As for breaking compatibility with older versions, I think there are still people out there being stuck on Ruby 1.9. What do you think about making one last release with 1.9 support and then dropping support for pre-2.1 rubies?
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
@joschi I was trying to update the gem and then noticed that rake version etc was giving error
NoMethodError: undefined method
dependencies_for' for #block in set_jeweler_defaults' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/specification.rb:41:in
chdir' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/specification.rb:41:inset_jeweler_defaults' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler.rb:37:in
initialize' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/tasks.rb:52:innew' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/tasks.rb:52:in
jeweler' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/jeweler-2.1.1/lib/jeweler/tasks.rb:82:inblock in define' /Users/tessy/.rvm/gems/ruby-2.4.1/gems/rake-12.1.0/exe/rake:27:in
<top (required)>' /Users/tessy/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:ineval' /Users/tessy/.rvm/gems/ruby-2.4.1/bin/ruby_executable_hooks:15:in
But now it showing a warning with nokogiri. I think this could be merged .Once this is done I could do the jeweler release. I tried fixing it. Updating nokogiri to the latest version would break older ruby versions. Let me know know your suggestions