search

graylog-labs / gelf-rb

Ruby GELF library (Graylog Extended Log Format)
https://rubygems.org/gems/gelf
MIT License
153 stars 104 forks source link

TLS Improvements and Fixes #68

Closed Stexxen closed 6 years ago

Stexxen commented 6 years ago

2 Commits. https://github.com/graylog-labs/gelf-rb/commit/c60c049c5671a31dd2edcde9a377becfcaf3e97a Adds the ability to allow the SSL Exceptions to rise up into the calling application. This is very useful when debugging TLS errors, as the current implementation just eats them, leaving the user none-the-wiser as to why things aren't working.

https://github.com/graylog-labs/gelf-rb/commit/28d35996d71a03eaf574233533ec9baf549cb760 Uses the correct syntax for the CipherString. The Jruby wrapper of SSL cannot take CipherNames directly and must use TXT constants from this list - https://github.com/jruby/jruby-openssl/blob/master/src/main/java/org/jruby/ext/openssl/CipherStrings.java#L47-L178

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

Stexxen commented 6 years ago

Hi, Is there anything more I should to do this PR to make it more likely to get merged?

milgner commented 6 years ago

I'll try adding TLSv1.2, too. jruby/jruby#1737 suggests that it will work.

milgner commented 6 years ago

Rebased this to resolve merge conflicts and pushed to master. Also added TLS 1.1 and 1.2 as well. Thank you for the contribution! :+1: If you have a JRuby application at hand, it would be fantastic if you could test current master with this change! I'm planning to release a new version next weekend, will be testing the current version with a TCP TLS connection on regular Ruby.