search

graylog-labs / gelf-rb

Ruby GELF library (Graylog Extended Log Format)
https://rubygems.org/gems/gelf
MIT License
153 stars 104 forks source link

Replace explicit Yajl support with MultiJson #73

Closed milgner closed 6 years ago

milgner commented 6 years ago

Replacement for #64

By using MultiJson, one can use oj or other JSON libraries besides yajl, too.

@tessie are you fine with introducing another dependency here?

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

milgner commented 6 years ago

On further thought, I'll make multi-json optional, too... just stumbled over https://github.com/ruby-grape/grape/pull/1623/files and found myself really liking their appraisal mechanism. Will check evaluate it for this gem as well...

milgner commented 6 years ago

As MultiJSON is somewhat deprecated by the original author, I'll close this for now.

repeatedly commented 5 years ago

How about other approach like #64? New gelf-rb breaks fluentd and it also breaks their k8s/fluentd/graylog setup so we need new gelf-rb with #63 fix...